-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fedora image #432
base: development
Are you sure you want to change the base?
Add Fedora image #432
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite understand what you've done. Is it running a fedora container on an ubuntu runner to build the documentation?
Yes! |
Why do we want to do that? 🤪 |
Because every time we had an in person meeting and the Fedora people tried to build the code all hell would break loose and we really should've been testing for this in the CI? |
That's a fair point. But in this PR as far as I can understand you've swapped Ubuntu for Fedora. Shouldn't we rather add it to the matrix of os's we run the CI on so that we test on both? Oh, I see why you used a container. GitHub actions doesn't offer Fedora in standard runners. |
See my note in the description: I wasn't sure how to do that elegantly given that Fedora uses an image, but the other two OS don't...?
Yes, unfortunately it doesn't. Although DPS mentioned that he's got a Fedora machine somewhere - unclear to me how much faff it would be to get this hooked up, though. |
It would be good to test on Fedora as well.
Wasn't sure how to hook this up with the fancy matrix because of the image, but that might be overkill anyway?
This is using the documentation step to test Fedora at the same time.