Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fedora image #432

Open
wants to merge 16 commits into
base: development
Choose a base branch
from
Open

Add Fedora image #432

wants to merge 16 commits into from

Conversation

20DM
Copy link
Collaborator

@20DM 20DM commented Sep 26, 2024

It would be good to test on Fedora as well.
Wasn't sure how to hook this up with the fancy matrix because of the image, but that might be overkill anyway?
This is using the documentation step to test Fedora at the same time.

@20DM 20DM changed the title WIP: Add Fedora image Add Fedora image Sep 26, 2024
@20DM 20DM requested a review from tkoskela September 26, 2024 16:28
Copy link
Contributor

@tkoskela tkoskela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite understand what you've done. Is it running a fedora container on an ubuntu runner to build the documentation?

@20DM
Copy link
Collaborator Author

20DM commented Sep 27, 2024

I don't quite understand what you've done. Is it running a fedora container on an ubuntu runner to build the documentation?

Yes!

@tkoskela
Copy link
Contributor

Why do we want to do that? 🤪

@20DM
Copy link
Collaborator Author

20DM commented Sep 27, 2024

Why do we want to do that? 🤪

Because every time we had an in person meeting and the Fedora people tried to build the code all hell would break loose and we really should've been testing for this in the CI?

@tkoskela
Copy link
Contributor

That's a fair point. But in this PR as far as I can understand you've swapped Ubuntu for Fedora. Shouldn't we rather add it to the matrix of os's we run the CI on so that we test on both?

Oh, I see why you used a container. GitHub actions doesn't offer Fedora in standard runners.

@20DM
Copy link
Collaborator Author

20DM commented Sep 27, 2024

That's a fair point. But in this PR as far as I can understand you've swapped Ubuntu for Fedora. Shouldn't we rather add it to the matrix of os's we run the CI on so that we test on both?

See my note in the description: I wasn't sure how to do that elegantly given that Fedora uses an image, but the other two OS don't...?

Oh, I see why you used a container. GitHub actions doesn't offer Fedora in standard runners.

Yes, unfortunately it doesn't. Although DPS mentioned that he's got a Fedora machine somewhere - unclear to me how much faff it would be to get this hooked up, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants