Iterative refinement support for JAX and NumPy forward (spherical) transform implementations #241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve #139
Adds support for using
iter
keyword argument tos2fft.forward
when usingmethod = "numpy"
andmethod = "jax"
, using an iterative refinement approach equivalent to that implemented inhealpy
to improve accuracy of forward transform (in terms of acting as the inverse of the inverse transform).Currently this is only added for spherical transform, and is available for all sampling types, even though in practice probably only useful for HEALPix (though
iter=1
does seem to give a small gain in accuracy for other sampling types).