Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix notebook plots #13

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Fix notebook plots #13

merged 1 commit into from
Nov 30, 2023

Conversation

henry-ald
Copy link
Collaborator

Adds the data_range argument to skimage.metrics functions peak_signal_noise_ratio and structural_similarity in accordance with the latest versions of skimage.metrics

tobias-liaudat
tobias-liaudat approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@tobias-liaudat tobias-liaudat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The modifications to the notebooks are ok. I think that the GitHub actions failed because they need to be updated. As it is not related to the PR, I'll accept it

@tobias-liaudat tobias-liaudat merged commit 7966d2b into main Nov 30, 2023
1 check failed
@henry-ald henry-ald deleted the henry-proxnest branch December 1, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobias-liaudat tobias-liaudat tobias-liaudat approved these changes

@CosmoMatt CosmoMatt Awaiting requested review from CosmoMatt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henry-ald @tobias-liaudat