Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

res_rtp_asterisk.c: Set mark on rtp when timestamp skew is too big #912

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

n2p-litvinov
Copy link

We faced with no audio issue when media source changed during the call (e.g. call transfer, audio prompt and then some sip endpoint, etc.). Issue related to big timestamp skew. Solution here is to set Mark when we detect such case.

@gtjoseph
Copy link
Member

@n2p-litvinov Is there an issue open for this? If not, you may want to open one. This allows the fix to be highlighted at the top of the changelog.

Copy link
Member

@gtjoseph gtjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

REMINDER: If this PR applies to other branches, please add a comment with the appropriate "cherry-pick-to" headers as per the Create a Pull Request process.

If you don't want it cherry-picked, please add a comment with cherry-pick-to: none so we don't keep asking.

If, after adding "cherry-pick-to" comments, you change your mind, please edit the comment to DELETE the header lines and add cherry-pick-to: none.

The currently active branches are now 18, 20, 21, 22 and master.

Set Mark bit in rtp stream when timestamp skew is bigger than MAX_TIMESTAMP_SKEW.

Fixes: asterisk#927
@n2p-litvinov
Copy link
Author

n2p-litvinov commented Oct 2, 2024

cherry-pick-to: 20
cherry-pick-to: 21
cherry-pick-to: 22

@n2p-litvinov
Copy link
Author

Thanks Joseph.
I created an issue. Commit message was corrected. PR was updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants