Remove a truckload of wasteful CSS #266

lachlanjc · 2015-04-11T19:37:35Z

I've searched the entire app for every class I've removed, and almost all the classes weren't being used at all. Lots more coming.

houndci-bot · 2015-04-11T19:37:39Z

app/assets/stylesheets/app/components/flip-grid.scss

@@ -120,7 +120,7 @@
    list-style: none;
    //
    &:hover {
-      background: $black;
+      background: rgba($black,.5);


.5 should be written with a leading zero as 0.5
Commas in function arguments should be followed by a single space

scss-lint says to do the opposite of both of those. Also, I'm hoping the horrible flip grid will be removed soon anyway, so I'm not going to fix this.

chrislloyd · 2015-04-13T17:34:34Z

Just looking into configuring Hound to Assembly style.

lachlanjc · 2015-04-13T18:05:04Z

@chrislloyd With the semicolon, that's actually necessary. (It's ok since there isn't another @import, but if there was we'd have an error. I'll fix that now.)

But yeah, that'd be awesome.

chrislloyd · 2015-04-13T18:38:52Z

I just pulled this down and it looks like border colors are off:

Also, it looks like borders on the footer are extending wide:

and the about page looks a little off:

lachlanjc · 2015-04-13T19:55:46Z

Sorry @chrislloyd!

Hmm, ok. I'll take a look at that…not sure what happened.
Crap, got it. I rewrote that but couldn't test it.
Yep. Just merge in the About page refactoring first — I accidentally deleted the styling on this branch as well as on the other. Should I bring it back?

lachlanjc · 2015-04-14T02:58:10Z

@chrislloyd

Just pushed a fix.
Works on my machine :) (it actually does — I'm not seeing that issue at any viewport size, tested on Vivaldi & Chrome)
I've brought it back. There doesn't appear to be any zombie emoji for the occasion, though.

lachlanjc · 2015-04-14T03:38:27Z

It seemed that the owl imports were causing the merge conflicts, but even removing those I can't get things to work. Any other ideas @chrislloyd?

whatupdave · 2015-04-23T21:46:36Z

How's this looking? Would love to merge :D

lachlanjc · 2015-04-23T21:47:24Z

Yeah, definitely. How can I figure out what the conflicts are?

whatupdave · 2015-04-23T21:54:01Z

Try rebasing this branch css-refactor onto master. Which will be something like:

git pull --rebase upstream master

This should give you a bunch of merge conflicts. Resolve those and then:

git add -A
git rebase --continue

Then force push the branch:

git push -f origin css-refactor

These are being overridden in the browser by `utilities/_type`

lachlanjc · 2015-04-24T01:28:01Z

@whatupdave I think I’ve fixed it up, thanks for that!

lachlanjc · 2015-05-08T02:13:44Z

@whatupdave @mdeiters @chrislloyd Let’s get this merged :)

mdeiters · 2015-05-08T18:22:22Z

@whatupdave is out today but we'll get this merged soon @lachlanjc :D

houndci-bot · 2015-05-15T12:15:14Z

app/assets/javascripts/lib/bootstrap-lightbox.js

 		if (this.isShown && this.options.backdrop)
 		{
 			var doAnimate = $.support.transition && animate;

-			this.$backdrop = $('<div class="modal-backdrop ' + animate + '" />')
-				.appendTo(document.body);
+			this.$backdrop = $("<div class='bg-black " + animate + "' />").appendTo(document.body);


Line is too long.

houndci-bot · 2015-05-15T12:17:41Z

app/assets/javascripts/lib/bootstrap-lightbox.js

-				var transition = $.support.transition && that.$element.hasClass('fade');
+		this.preloadSize(function() {
+			that.backdrop(function () {
+				var transition = $.support.transition && that.$element.hasClass("muted");


Line is too long.

houndci-bot · 2015-05-26T21:46:35Z

app/assets/javascripts/routes/products_handlers.js

@@ -99,6 +100,11 @@ let ProductsHandlers = {
      type: ActionTypes.PRODUCT_RECEIVE,
      product: product
    });
+
+    Dispatcher.dispatch({


Expected ',' and instead saw '.'.
Expected ',' and instead saw '('.
Expected an identifier and instead saw '{'.

lachlanjc · 2015-06-01T23:37:32Z

@whatupdave Travis says we’re using a deprecated method for email delivery here: spec/models/wip/worker_spec.rb:36. Could you please take a look at that?

lachlanjc · 2015-06-02T00:56:57Z

Ok, we should be good to go for CSS here.

lachlanjc · 2015-06-03T12:13:02Z

There's one little issue on the padding of bounty lists. I've fixed it but have no Wi-Fi on my 💻. I'll push it up this afternoon (along with another new PR).

lachlanjc · 2015-06-03T20:28:16Z

Ok, issue fixed!

houndci-bot · 2015-06-03T20:28:42Z

app/assets/stylesheets/app/components/deprecated_card.scss

@@ -58,7 +58,7 @@ a.deprecated-card:hover {
  padding: 20px;
 }

-.deprecated-card-footer {
+.deprecated-bg-gray-5 py2 px1 {


Selector should have depth of applicability no greater than 2, but was 3

houndci-bot · 2015-06-03T23:33:51Z

app/assets/stylesheets/app/components/deprecated_card.scss

-    @include transition-timing-function($transition-function);
-  }
+.deprecated-card-inner {
+  position: absolute;


Rule sets should be ordered as follows: @extends, @includes without @content, properties, @includes with @content, nested rule sets
Properties should be ordered background-position, background-size, display, height, opacity, position, width

houndci-bot reviewed Apr 11, 2015
View reviewed changes

lachlanjc added 14 commits April 23, 2015 21:19

Remove unused list classes

39ec89a

Remove duplicated text styles

4fb0d91

These are being overridden in the browser by `utilities/_type`

Remove a *lot* of completely unused CSS

755a97e

Remove more components

5d2c9eb

More 🚿 on the CSS

ac54680

Remove Bootstrap thumbnails

c06cb21

Fix Bootstrap input addon bg color

13e2bf7

Remove even more unused CSS

dcf7a08

Remove duplicated basscss-border code

bc2e76c

Remove .img-rounded

a9409fb

Clean up footer

67f439b

Remove .play-button and .masthead-gradient

472d9bc

Consistent quotes on app.scss

ab182b5

Fix border color

15deb9e

lachlanjc force-pushed the css-refactor branch from c801006 to 15deb9e Compare April 24, 2015 01:27

houndci-bot reviewed May 15, 2015
View reviewed changes

Clean up whitespace on lightbox js

80fc030

houndci-bot reviewed May 15, 2015
View reviewed changes

🚚💩

cbeb494

houndci-bot reviewed May 26, 2015
View reviewed changes

Fix for variables

80f3e8b

Fix Bounty display issue

a77dc96

houndci-bot reviewed Jun 3, 2015
View reviewed changes

Fix weird things

54044db

houndci-bot reviewed Jun 3, 2015
View reviewed changes

lachlanjc changed the title ~~Remove a lot of unused CSS~~ Remove a lot of unused & wasteful CSS Jun 3, 2015

lachlanjc changed the title ~~Remove a lot of unused & wasteful CSS~~ Remove a truckload of wasteful CSS Jun 6, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove a truckload of wasteful CSS #266

Remove a truckload of wasteful CSS #266

lachlanjc commented Apr 11, 2015

houndci-bot Apr 11, 2015

lachlanjc Apr 11, 2015

chrislloyd commented Apr 13, 2015

lachlanjc commented Apr 13, 2015

chrislloyd commented Apr 13, 2015

lachlanjc commented Apr 13, 2015

lachlanjc commented Apr 14, 2015

lachlanjc commented Apr 14, 2015

whatupdave commented Apr 23, 2015

lachlanjc commented Apr 23, 2015

whatupdave commented Apr 23, 2015

lachlanjc commented Apr 24, 2015

lachlanjc commented May 8, 2015

mdeiters commented May 8, 2015

houndci-bot May 15, 2015

houndci-bot May 15, 2015

houndci-bot May 26, 2015

lachlanjc commented Jun 1, 2015

lachlanjc commented Jun 2, 2015

lachlanjc commented Jun 3, 2015

lachlanjc commented Jun 3, 2015

houndci-bot Jun 3, 2015

houndci-bot Jun 3, 2015

Remove a truckload of wasteful CSS #266

Are you sure you want to change the base?

Remove a truckload of wasteful CSS #266

Conversation

lachlanjc commented Apr 11, 2015

houndci-bot Apr 11, 2015

Choose a reason for hiding this comment

lachlanjc Apr 11, 2015

Choose a reason for hiding this comment

chrislloyd commented Apr 13, 2015

lachlanjc commented Apr 13, 2015

chrislloyd commented Apr 13, 2015

lachlanjc commented Apr 13, 2015

lachlanjc commented Apr 14, 2015

lachlanjc commented Apr 14, 2015

whatupdave commented Apr 23, 2015

lachlanjc commented Apr 23, 2015

whatupdave commented Apr 23, 2015

lachlanjc commented Apr 24, 2015

lachlanjc commented May 8, 2015

mdeiters commented May 8, 2015

houndci-bot May 15, 2015

Choose a reason for hiding this comment

houndci-bot May 15, 2015

Choose a reason for hiding this comment

houndci-bot May 26, 2015

Choose a reason for hiding this comment

lachlanjc commented Jun 1, 2015

lachlanjc commented Jun 2, 2015

lachlanjc commented Jun 3, 2015

lachlanjc commented Jun 3, 2015

houndci-bot Jun 3, 2015

Choose a reason for hiding this comment

houndci-bot Jun 3, 2015

Choose a reason for hiding this comment