Do not wipe out context.data, breaking @key, @index, etc in partials #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problems addressed in #22 and #41.
In the code without my patch,
options.data
is set toundefined
, and then a few lines later we're merging all these objects, which causes the newly undefinedoptions.data
to wipe out any good object that we might have. As far as I can tell by tracing where options.data comes from and is used again, setting it to undefined again serves no useful purpose.Big thanks to @yongtw123 for pointing me in the right direction in #22.