Improvement suggestions: CuAssertStrnEquals(), Setup()/Teardown(), const void * ptr #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CuAssertStrnEquals_LineMsg(). These functions allow a partial compare of expected/actual strings. Code was originally contributed to the version of CuTest used by the serf project.
CuTest.c/CuAssertStrnEquals_LineMsg: Check for expected length == 0 first, the
actual data pointer is not necessarily initialized in that case.
Code was originally contributed to the version of CuTest used by the
serf project.
…d after every test. Code was originally contributed to the version of CuTest used by the serf project.
test that a 'const char *' value is NULL without cast.
…tions in license.txt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
Based on your account name I'm assuming this is the master repository of the CuTest code.
These are the changes that we have made to CuTest as used in the test suite of the serf project ( https://code.google.com/p/serf/ ). You're welcome to include them in your master copy of the code, for release under your preferred license.
Besides the improvements mentioned in the title, I've also added your license text in the source files per your instructions in license.txt. You'll probably want to remove the list of customisations in CuTest.h
thanks,
Lieven