Improve snapshot cropping algorithm

asciinema · Mar 18, 2024 · 29bfa86 · 29bfa86
1 parent 63a17c9
commit 29bfa86
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/asciinema/recordings/snapshot.ex b/lib/asciinema/recordings/snapshot.ex
@@ -214,7 +214,7 @@ defmodule Asciinema.Recordings.Snapshot do
   end
 
   defp blank_segment?({text, attrs, _char_width}) do
-    String.trim(text) == "" && attrs == %{}
+    String.trim(text) == "" && attrs["bg"] == nil
   end
 
   defp fill_to_height(lines, height) do

diff --git a/test/asciinema/recordings/snapshot_test.exs b/test/asciinema/recordings/snapshot_test.exs
@@ -58,7 +58,7 @@ defmodule Asciinema.Recordings.SnapshotTest do
                [
                  [["foobar", %{}, 1]],
                  [["bazquxquux", %{}, 1]],
-                 [],
+                 [[" ", %{fg: 5}, 1]],
                  []
                ],
                5,
-Original file line number
+Diff line change
@@ Expand Up / @@ -58,7 +58,7 @@ defmodule Asciinema.Recordings.SnapshotTest do @@
                    [
                      [["foobar", %{}, 1]],
                      [["bazquxquux", %{}, 1]],
-                     [],
+                     [[" ", %{fg: 5}, 1]],
                      []
                    ],
 ,
@@ Expand Down @@