-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added HOME and END support to all editor boxes. #103
base: master
Are you sure you want to change the base?
Conversation
MEOW! reveived the cute mailthingi.. and preparing a purr back maybe it takes a while
=^.^=
|
Ohi, thanks, it's a nice extension.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
I think that would make more sense if that was implemented using PageUp/PageDown. I will look into that.
It does this already except in the response body and headers boxes, as those wrap when the line is wider than the window. I'll have to look at how the wrapping is implemented in the code to see if this can be done in a way that isn't messy. |
Well, browsers work similarly as I described so it is pretty intuitive imho. When you hit "END" key it jumps to the bottom of the page except if the focus is on an input element. Also, PageUp/Down are already in use.
You're right, thanks. |
I see what you mean. I should be able to add in similar logic to here to do that. |
@chiefnoah any update on this? |
MEOW! reveived the cute mailthingi.. and preparing a purr back maybe it takes a while
=^.^=
|
@asciimoo I haven't had a chance to go back and look at it much. From what I could tell, there's no easy way to go to the end of a text area. It would require changes to gocui, as when I checked it didn't expose the number of lines in an edit window. This may have changed since I looked at it last. I should be able to revisit this in the near future. |
Worst case we can calculate it from the window's content and width.
Awesome, thanks. |
Fixes #69