-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for warnings #1735
Open
drkameleon
wants to merge
12
commits into
master
Choose a base branch
from
add-support-for-warnings
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add support for warnings #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drkameleon
added
vm
Issues related to the Virtual Machine implementation
error handling
Issues related to Error handling
library
Issues related to the standard library
labels
Sep 25, 2024
github-actions
bot
removed
vm
Issues related to the Virtual Machine implementation
error handling
Issues related to Error handling
library
Issues related to the standard library
labels
Sep 25, 2024
github-actions
bot
added
vm
Issues related to the Virtual Machine implementation
error handling
Issues related to Error handling
command line
Issues related to Arturo's command-line and options
labels
Sep 25, 2024
…dd-support-for-warnings # Conflicts: # version/build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
command line
Issues related to Arturo's command-line and options
error handling
Issues related to Error handling
vm
Issues related to the Virtual Machine implementation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After re-designing our Error system (with quite some success), we should also enable some form of Warning system.
This isn't going to be anything too elaborate, just a uniform way to support basic, non-throwing warning messages (e.g. "function X has been deprecated, use Y.").
Also, we should make it possible to make these warnings disappear on-demand - for example, based on a flag or sth along the lines.
Along with this new "feature", we should also add an library function (
warn
would sounds quite self-explanatory I think), which would go in the Exceptions (could be renamed? 🤔 )Let's go for it! 🚀
Type of change