refactor: shrink 17-artwork-multimodal import size #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mc-jones
commented
Nov 13, 2024
| @@ -60,8 +60,8 @@ export function resizeImage( | |||
| height: number | |||
| } | |||
| ) { | |||
| const { width, height } = defaults(options, { width: 500, height: 500 }) | |||
| return `https://d7hftxdivxxvm.cloudfront.net/?src=${src}&resize_to=fit&width=${width}&height=${height}&grow=false` | |||
| const { width, height } = defaults(options, { width: 224, height: 224 }) | |||
There was a problem hiding this comment.
This is the default resolution configured in the CLIP docs, so I have have copied that here. It is what has made the biggest difference.
mc-jones
commented
Nov 13, 2024
| @@ -114,6 +117,10 @@ async function prepareArtworkCollection() { | |||
| name: "artistGender", | |||
| dataType: ["text"], | |||
| }, | |||
| { | |||
| name: "isCurated", | |||
| dataType: ["boolean"], | |||
There was a problem hiding this comment.
@egdbear - decided to insert them into the same collection with a flag.
|
memory usage still feels a bit high, but this gets us a stable instance and the ability to continue testing. |
egdbear
reviewed
Nov 14, 2024
Comment on lines
+14
to
+15
| export async function getArtworks(filename: string) { | ||
| const filePath = path.join(__dirname, `./data/${filename}`) |
There was a problem hiding this comment.
suggestion: Maybe a filename could be optional here? Also this method is being used here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few changes aimed at shrinking the size of the imports to
weaviate. I have run a few batches with this configuration and the memory usage is much more in line with what we would expect to see:cc: @cavvia (not letting me add you as a reviewer...)