Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[msg] filter msgs without attachments or bodies if ignoreBlankMessages is true #917

Closed
wants to merge 1 commit into from

Conversation

sarahscott
Copy link
Contributor

@mzikherman
Copy link
Contributor

I'm not sure this is what we want, I think this logic needs to be implemented in Radiation, and the param passed through (from Metaphysics, to Impulse and then Radiation).

The reason is that the Relay pagination is going to get messed up otherwise- here the total count that we use in pagination (to determine hasNextPage, etc.) is coming from Radiation, and is counting even blank messages. That's why we should implement this upstream, that way the counts will be accurate.

@orta
Copy link
Contributor

orta commented Jan 30, 2018

Deprecated by #918

Discussion in slack

@orta orta closed this Jan 30, 2018
@orta orta deleted the sos-filter-blank-msgs branch January 30, 2018 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants