Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trace optimzations #828

Merged
merged 3 commits into from
Nov 22, 2017
Merged

Trace optimzations #828

merged 3 commits into from
Nov 22, 2017

Conversation

alloy
Copy link
Contributor

@alloy alloy commented Nov 22, 2017 •
edited
Loading

As discussed in Slack here are a few optimisations that:

  • Ensure processing is done after the response is sent to the client
  • Other code gets a chance to enqueue work
  • Only instrument resolvers of object types (we may be missing out on resolvers for scalar fields that do perform IO work, though)
  • Do not instrument resolvers of the introspection query

Better detection of interesting resolvers can be done by making them use async/await: #829

alloy added 3 commits November 22, 2017 17:51
@alloy
[tracing] Enqueue processing 1 by 1 after the response has been sent.
dc5aa23 
Scheduling each span to be processed only after a previous one has been
finished means that other code gets a chance to also schedule work in
between.
@alloy
[tracing] Only instrument resolvers of object type fields.
0574d25
@alloy
[tracing] Don’t instrument introspection query resolvers.
994aa62
@saolsen
Copy link
Contributor

saolsen commented Nov 22, 2017

Great!

@saolsen saolsen merged commit aa0a115 into master Nov 22, 2017
@yuki24 yuki24 deleted the trace-optimzations branch February 18, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@saolsen saolsen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alloy @saolsen