Stitching issues/namespacing

[mzikherman]

We have a Category type (https://github.com/artsy/convection/blob/2262bfdecc87a8d7e30f2f144b980d401849eeb3/app/graph/types/category_type.rb#L2) in Convection that is clobbering a local type in MP:

metaphysics/src/schema/partner.js

Line 23 in 91c249d

name: "Category",

This is causing Market Insights to be broken in Production.

This also is preventing us from turning this feature flag on in production (cc @joeyAghion @orta )

Proposal: all conflicting types that currently exist need to be whitelisted (if one should overwrite and take precedence another), or, in this case- they need to be renamed or namespaced at merge time.

[mzikherman]

cc @sweir27

Auction pages are broken on staging, see https://artsy.slack.com/archives/C9RU02REJ/p1524254326000402 for a more in-depth discussion.

It looks like an issue with querying multiple things at the root on the merged schema:

artwork {

}
sales {

}

[alloy]

There’s also #833. Should that be closed?

[orta]

I have a test for

artwork {

}
sales {

}

in #1032 and it doesn't fail. So maybe in the graphql-tools updates, it got fixed? https://github.com/artsy/metaphysics/pull/1032/files#diff-d31a8dd3038dea5e2eaa799da25c1080R53