chore: (NOMERGE) open action prompt in a new window instead of the modal for order actions in conversations #15046
+68
−146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves [https://artsyproduct.atlassian.net/browse/EMI-2218]
This is just removing the modal and opening the appropriate order in the new tab regardless of the state of the order. We currently have this modal opened for multiple states (counteroffer received in different variations, order approved, order payment failing, etc). So I applied this 'open in the new window' across the board.
Need to discuss with Cami and Vivi what is the appropriate flow we want at the end but for now confirmed with Cami that it's good enough of a change. For now don't want to merge this immediately as we want to have a bit of time to test it before putting it out (mainly make sure there is no major objections to this flow).
So if all looks well - we should merge it when more people from the team is around and can play with it.