Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: (NOMERGE) open action prompt in a new window instead of the modal for order actions in conversations #15046

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oxaudo
Copy link
Member

@oxaudo oxaudo commented Dec 24, 2024

This PR solves [https://artsyproduct.atlassian.net/browse/EMI-2218]

This is just removing the modal and opening the appropriate order in the new tab regardless of the state of the order. We currently have this modal opened for multiple states (counteroffer received in different variations, order approved, order payment failing, etc). So I applied this 'open in the new window' across the board.

Need to discuss with Cami and Vivi what is the appropriate flow we want at the end but for now confirmed with Cami that it's good enough of a change. For now don't want to merge this immediately as we want to have a bit of time to test it before putting it out (mainly make sure there is no major objections to this flow).

So if all looks well - we should merge it when more people from the team is around and can play with it.

@oxaudo oxaudo requested a review from MrSltun December 24, 2024 18:55
@oxaudo oxaudo self-assigned this Dec 24, 2024
Copy link

relativeci bot commented Dec 24, 2024

#1419 Bundle Size — 8.95MiB (~-0.01%).

883f0aa(current) vs c98a697 main#1416(baseline)

Warning

Bundle contains 14 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#1419
     Baseline
#1416
No change  Initial JS 3.65MiB 3.65MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 40.8% 80.28%
No change  Chunks 103 103
No change  Assets 106 106
No change  Modules 5836 5836
No change  Duplicate Modules 529 529
No change  Duplicate Code 4.02% 4.02%
No change  Packages 266 266
No change  Duplicate Packages 13 13
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
#1419
     Baseline
#1416
Improvement  JS 8.81MiB (~-0.01%) 8.81MiB
No change  Other 143.36KiB 143.36KiB

Bundle analysis reportBranch oxaudo/nomodalProject dashboard


Generated by RelativeCIDocumentationReport issue

@oxaudo oxaudo changed the title chore (NOMERGE): open action prompt in a new window instead of the modal for order actions in conversations chore: (NOMERGE) open action prompt in a new window instead of the modal for order actions in conversations Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants