Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Unite suggested filters and applied filters #9593

Closed

Conversation

MounirDhahri
Copy link
Member

Description

This PR brings the suggested filters together with the applied filters.

Screen.Recording.2023-11-23.at.15.22.48.mov

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • Combine suggested filters and applied filters - mounir

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@MounirDhahri MounirDhahri self-assigned this Nov 23, 2023
@MounirDhahri MounirDhahri marked this pull request as ready for review November 23, 2023 14:30
@ArtsyOpenSource
Copy link
Contributor

This PR contains the following changes:

  • Cross-platform user-facing changes (Combine suggested filters and applied filters - mounir)

Generated by 🚫 dangerJS against ee879e2

@MounirDhahri MounirDhahri marked this pull request as draft November 23, 2023 15:07
@MounirDhahri MounirDhahri force-pushed the chore/address-qa-comments-suggested-filters branch from 382ae09 to e1c671a Compare November 23, 2023 16:29
Base automatically changed from chore/address-qa-comments-suggested-filters to main November 23, 2023 16:37
@MounirDhahri MounirDhahri changed the title chore: add filter suggestions to applied filters chore: Unite suggested filters and applied filters Dec 12, 2023
@MounirDhahri
Copy link
Member Author

Closing this since we decided not to follow this direction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants