chore: cleanup unused uploadMiddleware #9587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR contains the following changes:
|
| @@ -17,7 +17,6 @@ import { | |||
| import { rateLimitMiddleware } from "./middlewares/rateLimitMiddleware" | |||
| import { simpleLoggerMiddleware } from "./middlewares/simpleLoggerMiddleware" | |||
| import { timingMiddleware } from "./middlewares/timingMiddleware" | |||
| import { uploadMiddleware } from "./middlewares/uploadMiddleware" | |||
There was a problem hiding this comment.
Q: Should we revert to using the default uploadMiddleware from react-relay-network-modern/node8 as before we rolled out this here
There was a problem hiding this comment.
Ooops, you are right, on it!
brainbicycle
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves ONYX-504
Description
Onyx is cleaning up code related to the TinEye reverse image search project. Mostly the code was already removed by @gkartalis here #8898, but there were some leftovers introduces in these PRs:
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.