fix: marketing link tracking #9445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkartalis
commented
Oct 18, 2023
src/app/utils/useDeepLinks.ts
Outdated
Comment on lines
33
to
34
| // track deep link tap | ||
| trackEvent(tracks.deepLink(url)) |
There was a problem hiding this comment.
right now if a user is logged out we track the deeplink tap even if they land on the login page and never actually get navigated to the sceen. Do we want to change that to track right before navigating to the page ?
gkartalis
requested review from
brainbicycle,
araujobarret,
MrSltun and
MounirDhahri
|
asked here for the deeplink payload https://artsy.slack.com/archives/C03NF9TKR/p1697645671461019 |
|
Testing + Adding new videos for the refactored behavior |
gkartalis
commented
Oct 19, 2023
Comment on lines
+71
to
+85
| let response | ||
| try { | ||
| response = await fetch(targetURL) | ||
| } catch (error) { | ||
| if (__DEV__) { | ||
| console.warn(error) | ||
| } else { | ||
| captureMessage( | ||
| `[navigate] Error fetching marketing url redirect on: ${targetURL} failed with error: ${error}`, | ||
| "error" | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| if (response?.url) { |
There was a problem hiding this comment.
unrelated - just adding a catch to this fetch
Comment on lines
-51
to
-55
| // These will be redirected, avoided double tracking | ||
| if (!launchURL.current.includes("click.artsy.net")) { | ||
| trackEvent(tracks.deepLink(launchURL.current)) | ||
| } | ||
|
|
There was a problem hiding this comment.
this was causing double tracking for logged out users (for non-marketing links)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves PHIRE-343
Description
Fixes marketing link tracking - tested on iOS ✅
Fixes double tracking on normal deep links for logged out users - tested on iOS ✅
More info on decisions can be found here
and for the bonus bug fix ar
Warning
Would like for at least 1 person to test with any
click.artsy.netlink from an email with an android device if possible since yarn open-url doesn't work with androidRPReplay_Final1697631595.MP4
Screen.Recording.2023-10-19.at.17.22.18.mov
RPReplay_Final1697631693.MP4
Screen.Recording.2023-10-19.at.17.54.39.mov
Note
Also fixes a double tracking bug that we had for logged out users - removed tracking from inside
useEffect(see more context on this slack threadPR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.