Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(ci): workflow review take 2 #9429

Merged
merged 11 commits into from
Oct 17, 2023
Merged

build(ci): workflow review take 2 #9429

merged 11 commits into from
Oct 17, 2023

Conversation

brainbicycle
Copy link
Contributor

@brainbicycle brainbicycle commented Oct 16, 2023

This reverts commit b2d1c70.

This PR resolves []

Brings back the work flow review from before.

Restores this PR: #9400

Job was failing before due to not clearing out project directory before cloning.

Description

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • simplify ci workflows - brian

Need help with something? Have a look at our docs, or get in touch with us.

@brainbicycle brainbicycle self-assigned this Oct 16, 2023
@brainbicycle brainbicycle marked this pull request as draft October 16, 2023 16:36
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Oct 16, 2023

This PR contains the following changes:

  • Dev changes (simplify ci workflows - brian)

Generated by 🚫 dangerJS against 6a9cca7

@brainbicycle brainbicycle marked this pull request as ready for review October 16, 2023 19:09
@brainbicycle brainbicycle changed the title Revert "Revert: "build(ci): workflow review" (#9414)" build(ci): workflow review take 2 Oct 17, 2023
@brainbicycle brainbicycle merged commit 03a7daa into main Oct 17, 2023
@brainbicycle brainbicycle deleted the brian/workflow-redux branch October 17, 2023 18:23
brainbicycle added a commit that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants