feat(ONYX-380): add colours filter to saved searches #9413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MounirDhahri
force-pushed
the
feat/add-color-filter
branch
from
4c8a5ac to
9c67567
Compare
olerichter00
previously approved these changes
Oct 12, 2023
| import { SavedSearchStore } from "app/Scenes/SavedSearchAlert/SavedSearchStore" | ||
| import { isValueSelected, useSearchCriteriaAttributes } from "app/Scenes/SavedSearchAlert/helpers" | ||
|
|
||
| export const SavedSearchFilterColour = () => { |
There was a problem hiding this comment.
Not sure whether devs from the US will be happy with colour 😆
There was a problem hiding this comment.
lol - did it intentionally here to follow Barney's designs 😄
src/app/Scenes/SavedSearchAlert/Components/SavedSearchFilterColour.tsx
Outdated
Show resolved
Hide resolved
MounirDhahri
added
the
Squash On Green
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves ONYX-380
Description
This PR adds color filtering to saved searches filter
Screen.Recording.2023-10-12.at.15.54.33.mov
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.