-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add medium filtering to saved seaches #9412
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MounirDhahri
force-pushed
the
feat/add-medium-filter
branch
from
October 12, 2023 14:23
1cb1f8d
to
b03c684
Compare
olerichter00
previously approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌟 🌟 🌟
Comment on lines
+10
to
+11
attributionClass = "attributionClass", | ||
colors = "colors", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
MounirDhahri
added
Squash On Green
A label to indicate that Peril should squash-merge this PR when all statuses are green
and removed
Squash On Green
A label to indicate that Peril should squash-merge this PR when all statuses are green
labels
Oct 12, 2023
MounirDhahri
force-pushed
the
feat/add-medium-filter
branch
from
October 12, 2023 16:33
933719e
to
c88c6ed
Compare
MounirDhahri
force-pushed
the
feat/add-medium-filter
branch
3 times, most recently
from
October 17, 2023 08:45
901a4e6
to
c2c1e4b
Compare
olerichter00
previously approved these changes
Oct 17, 2023
MounirDhahri
force-pushed
the
feat/add-medium-filter
branch
from
October 17, 2023 09:33
f479065
to
4059624
Compare
MounirDhahri
added
the
Squash On Green
A label to indicate that Peril should squash-merge this PR when all statuses are green
label
Oct 17, 2023
Another merge conflict 😢 |
MounirDhahri
force-pushed
the
feat/add-medium-filter
branch
from
October 17, 2023 09:42
4059624
to
e0d9b42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Jira Synced
Squash On Green
A label to indicate that Peril should squash-merge this PR when all statuses are green
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves ONYX-413
Description
This PR adds medium filtering to saved searches filters.
Why so many commits? 😄
While working on this PR I noticed few things that needed to be fixed along the way
Screen.Recording.2023-10-17.at.10.49.14.mov
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.