Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add medium filtering to saved seaches #9412

Merged
merged 39 commits into from
Oct 17, 2023
Merged

Conversation

MounirDhahri
Copy link
Member

@MounirDhahri MounirDhahri commented Oct 12, 2023

This PR resolves ONYX-413

Description

This PR adds medium filtering to saved searches filters.

Why so many commits? 😄

While working on this PR I noticed few things that needed to be fixed along the way

  • The list of additionalGenes that were injected in tests, were not exact. We send values and not labels, this needed to be fixed.
  • The list of categories that we have in Eigen, is targeted towards my collection artworks and not for gravity, we needed to create a separate list based on Gravity. The list is stable, no need to query for it.
  • Some of the tests started breaking as I made the changes and they needed to be updated (didn't remove any)
Screen.Recording.2023-10-17.at.10.49.14.mov

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • add medium filtering to saved searches - mounir

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@MounirDhahri MounirDhahri self-assigned this Oct 12, 2023
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Oct 12, 2023

This PR contains the following changes:

  • Cross-platform user-facing changes (add medium filtering to saved searches - mounir)

Generated by 🚫 dangerJS against 4059624

olerichter00
olerichter00 previously approved these changes Oct 12, 2023
Copy link
Contributor

@olerichter00 olerichter00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟 🌟 🌟

Comment on lines +10 to +11
attributionClass = "attributionClass",
colors = "colors",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@MounirDhahri MounirDhahri added Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green and removed Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green labels Oct 12, 2023
@MounirDhahri MounirDhahri force-pushed the feat/add-medium-filter branch from 933719e to c88c6ed Compare October 12, 2023 16:33
@MounirDhahri MounirDhahri marked this pull request as draft October 13, 2023 12:54
@MounirDhahri MounirDhahri force-pushed the feat/add-medium-filter branch 3 times, most recently from 901a4e6 to c2c1e4b Compare October 17, 2023 08:45
@MounirDhahri MounirDhahri marked this pull request as ready for review October 17, 2023 08:55
olerichter00
olerichter00 previously approved these changes Oct 17, 2023
@MounirDhahri MounirDhahri force-pushed the feat/add-medium-filter branch from f479065 to 4059624 Compare October 17, 2023 09:33
@MounirDhahri MounirDhahri added the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label Oct 17, 2023
@MounirDhahri
Copy link
Member Author

Another merge conflict 😢

@MounirDhahri MounirDhahri force-pushed the feat/add-medium-filter branch from 4059624 to e0d9b42 Compare October 17, 2023 09:42
@artsy-peril artsy-peril bot merged commit e06782d into main Oct 17, 2023
@artsy-peril artsy-peril bot deleted the feat/add-medium-filter branch October 17, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jira Synced Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants