Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(ci): don't spam us with native code notification #9384

Merged
merged 11 commits into from
Oct 9, 2023
Merged

Conversation

brainbicycle
Copy link
Contributor

@brainbicycle brainbicycle commented Oct 5, 2023

This PR resolves []

Description

The old approach storing the native-hash in the circle cache was flawed because circle won't overwrite the stored cache unless you change the name, which we don't want because we want this to persist between jobs.

New approach:

  • use s3 and store the hash in a file native-hash.txt
  • to avoid spam also store a timestamp and only notify if we have not notified in the last 24 hours

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • Only notify once per native code change - Brian

Need help with something? Have a look at our docs, or get in touch with us.

@brainbicycle brainbicycle self-assigned this Oct 5, 2023
@brainbicycle brainbicycle marked this pull request as draft October 5, 2023 13:29
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Oct 5, 2023

This PR contains the following changes:

  • Dev changes (Only notify once per native code change - Brian)

Generated by 🚫 dangerJS against 4c7a2b5

@brainbicycle brainbicycle removed their assignment Oct 5, 2023
@brainbicycle brainbicycle marked this pull request as ready for review October 5, 2023 18:32
@gkartalis gkartalis merged commit 30c1e37 into main Oct 9, 2023
1 check passed
@gkartalis gkartalis deleted the brian/stop-spam branch October 9, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants