-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): remove native code + unused pods #9364
Conversation
Thank you for following up on this 👍 |
@@ -43,4 +43,7 @@ | |||
/// <br/> (#0eda83) | |||
+ (UIColor *)artsyGreenRegular; | |||
|
|||
// Allow creating colors with a hex code | |||
+ (UIColor *)ar_colorWithHex:(UInt32)hex; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exposing a convenience method we already had to get rid of EDColor which we were using for same purpose
#import <ObjectiveSugar/ObjectiveSugar.h> | ||
#import <React/RCTDevSettings.h> | ||
#import <React/RCTBridge.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
most of the header file deletions / noise is just removing and check to see if it still compiles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on fire! 🧹🧹🧹🧹
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks Brian
This PR resolves PHIRE-139
Description
Removes some old pods that are no longer necessary:
Removes some old native code:
Cleans up unused imports:
Follow-ups
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.