Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): remove native code + unused pods #9364

Merged
merged 22 commits into from
Oct 4, 2023
Merged

Conversation

brainbicycle
Copy link
Contributor

@brainbicycle brainbicycle commented Oct 2, 2023

This PR resolves PHIRE-139

Description

Removes some old pods that are no longer necessary:

  • AROAuth previously used for twitter auth, not used in a long time
  • AFNetworking, we are only using some of the subspecs, removed the rest
  • EDColor, was used for some convenience methods but we have an extension that does the same thing
  • ARGenericTableViewController, was only used in old admin menu

Removes some old native code:

  • Old admin menu, this has some cool tools but hasn't been given attention in a long time and most are broken, getting rid of let's us get rid of a fair bit of code

Cleans up unused imports:

  • Went through a bunch of files checking for unused imports, there were quite a few

Follow-ups

  • Remove more code!

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • Remove unused code + native dependencies - Brian

Need help with something? Have a look at our docs, or get in touch with us.

@brainbicycle brainbicycle self-assigned this Oct 2, 2023
@brainbicycle brainbicycle marked this pull request as draft October 2, 2023 16:50
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Oct 2, 2023

This PR contains the following changes:

  • Dev changes (Remove unused code + native dependencies - Brian)

Generated by 🚫 dangerJS against 63437df

@damassi
Copy link
Member

damassi commented Oct 2, 2023

Thank you for following up on this 👍

@brainbicycle brainbicycle marked this pull request as ready for review October 2, 2023 17:50
@@ -43,4 +43,7 @@
/// <br/> (#0eda83)
+ (UIColor *)artsyGreenRegular;

// Allow creating colors with a hex code
+ (UIColor *)ar_colorWithHex:(UInt32)hex;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exposing a convenience method we already had to get rid of EDColor which we were using for same purpose

#import <ObjectiveSugar/ObjectiveSugar.h>
#import <React/RCTDevSettings.h>
#import <React/RCTBridge.h>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of the header file deletions / noise is just removing and check to see if it still compiles.

@brainbicycle brainbicycle requested review from MounirDhahri and a team October 3, 2023 13:00
Copy link
Member

@gkartalis gkartalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on fire! 🧹🧹🧹🧹

Copy link
Member

@MounirDhahri MounirDhahri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks Brian

@brainbicycle brainbicycle merged commit 5213db1 into main Oct 4, 2023
1 check passed
@brainbicycle brainbicycle deleted the brian/build-times branch October 4, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants