Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps @artsy/palette => 11.0.0 #3459

Merged
merged 4 commits into from
Jun 17, 2020
Merged

Bumps @artsy/palette => 11.0.0 #3459

merged 4 commits into from
Jun 17, 2020

Conversation

dzucconi
Copy link
Member

@dzucconi dzucconi commented Jun 15, 2020

Re: artsy/palette#707

Minor breaking change in this release where the flexGrow/Shrink props are a bit more strict.

#trival

@dzucconi
Copy link
Member Author

OK, weird this is just flat out wrong — investigating

Invariant Violation: Invalid prop `borderRadius` of type `string` supplied to `StyleSheet generated`, expected `number`.
    StyleSheet generated: {
      "borderRadius": "50%"
    }

@dzucconi
Copy link
Member Author

OH, it's the expectation that's wrong, not the type. I updated the avatar component to use a 50% borderRadius instead of a manual one.

@dzucconi
Copy link
Member Author

Ah, OK, apparently RN can't have a 50% borderRadius and it has to be a number. I'll release a patch and make sure that's commented :\

@ashfurrow
Copy link
Contributor

Ah weird! Thanks!

@dzucconi
Copy link
Member Author

K — should be good now!

@artsy-peril artsy-peril bot merged commit e24e818 into master Jun 17, 2020
@artsy-peril artsy-peril bot deleted the chore/palette branch June 17, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants