Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(EMI-2217): Animate tasks on tap or clear #11325

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

MrSltun
Copy link
Member

@MrSltun MrSltun commented Dec 24, 2024

This PR resolves EMI-2217

Description

This PR adds animation to each task on the homeview tasks list

Important

This PR adds a patch to react-native-reanimated to support adding a zIndex to the flatlist elements

After multiple approaches not to go with Reanimated (mainly due to it not supporting CellRendererComponent prop), there was no option but to use reanimated and patch the package to support CellRendererComponent, which allowed us to use the itemLayoutAnimation and animate the items in the flatlist

Videos

Before After
Android
animate-tasks-android-before-low.mp4
animate-tasks-android-after-low.mp4
iOS
animate-tasks-ios-before-low.mp4
animate-tasks-ios-after-low.mp4

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • Animate tasks on tap or clear

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@MrSltun MrSltun requested a review from a team December 24, 2024 09:17
@MrSltun MrSltun self-assigned this Dec 24, 2024
@ArtsyOpenSource
Copy link
Contributor

This PR contains the following changes:

  • Cross-platform user-facing changes (Animate tasks on tap or clear - MrSltun)

Generated by 🚫 dangerJS against 8866277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants