fix(ONYX-1442): adjust HomeViewSectionCard component for bigger screens #11321
+93
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariakoko
commented
Dec 20, 2024
Comment on lines
-31
to
-34
| export type HeroUnitItem = ExtractNodeType< | ||
| HomeViewSectionHeroUnits_section$data["heroUnitsConnection"] | ||
| > | ||
|
|
There was a problem hiding this comment.
Removing this type definition in favor of interface HeroUnitItemProps because the old type definition does not allow to reuse the component due to different shape of types
For example this does not work:
type HeroUnitItem =
| NonNullable<HomeViewSectionCard_section$data["card"]>
| ExtractNodeType<HomeViewSectionHeroUnits_section$data["heroUnitsConnection"]>
Am I right for doing so of there is a better way?
There was a problem hiding this comment.
What reuse are you referring to? These components should be fairly specific to the homeView schema and screen so I'm surprised we can't keep this typing as is and address any errors in item access elsewhere.
There was a problem hiding this comment.
I am reusing HeroUnit component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves ONYX-1442
Description
Adjust the image on the HomeViewSectionCards component on iPad
Before
After
Screen.Recording.2024-12-20.at.13.39.44.mov
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.