-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade react native to 0.76 #11316
Open
brainbicycle
wants to merge
12
commits into
main
Choose a base branch
from
brian/upgrade-rn
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,428
−1,379
Open
Changes from 4 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c84e278
react native upgrade diff
brainbicycle a5f1dc6
update deployment target to 15.1
brainbicycle 76fd6d3
update deployment target to 15.1 in podfile
brainbicycle 19ae982
install deps after rn upgrade
brainbicycle c741049
upgrade segment plugin to fix android build issue
brainbicycle 2700f59
Merge remote-tracking branch 'origin/main' into brian/upgrade-rn
brainbicycle 50596fa
fix deps after bad merge
brainbicycle f8e27e9
try upgrading react-native-svg to fix build failure
brainbicycle c62c859
remove now unused patch for flipper
brainbicycle e3f57e6
missed native side update for rnsvg
brainbicycle 63abe82
remove now included dev menu native module
brainbicycle 1bbf875
upgrade heap size to fix android initial builds
brainbicycle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,7 +14,7 @@ require Pod::Executable.execute_command('node', ['-p', | |
)', __dir__]).strip | ||
|
||
project 'Artsy.xcodeproj' | ||
platform :ios, '14.0' | ||
platform :ios, '15.1' | ||
inhibit_all_warnings! # ignore all warnings from all pods | ||
|
||
prepare_react_native_project! | ||
|
@@ -68,7 +68,8 @@ target 'Artsy' do | |
:path => config[:reactNativePath], | ||
:production => ENV['CIRCLE_BUILD_NUM'], | ||
# An absolute path to your application root. | ||
:app_path => "#{Pod::Config.instance.installation_root}/.." | ||
:app_path => "#{Pod::Config.instance.installation_root}/..", | ||
new_arch_enabled: false | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. need to opt out of new arch for now, similar setting in gradle file for android |
||
) | ||
|
||
# Networking | ||
|
@@ -163,7 +164,7 @@ target 'Artsy' do | |
config.build_settings['EXPANDED_CODE_SIGN_IDENTITY'] = "" | ||
config.build_settings['CODE_SIGNING_REQUIRED'] = "NO" | ||
config.build_settings['CODE_SIGNING_ALLOWED'] = "NO" | ||
config.build_settings["IPHONEOS_DEPLOYMENT_TARGET"] = "14.0" | ||
config.build_settings["IPHONEOS_DEPLOYMENT_TARGET"] = "15.1" | ||
end | ||
end | ||
end | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
turns out the deployment target upgrade is an RN requirement not an expo requirement 👍