[wip] fix: Update tasks list using the relay store #11247
Conversation
| if (!!taskAcknowledged) { | ||
| ConnectionHandler.deleteNode(tasksConnection, taskID) | ||
| } |
There was a problem hiding this comment.
non-blocking: If it is possible to include the fragment that gets the list of tasks in your mutation gql fields, then the relevant store data will be updated without needing to get surgical (you could still use an optimistic update to temporarily remove that task). I think this would be something like here - ...HomeViewSectionTasks_section so maybe not easy to access from this mutation.
There was a problem hiding this comment.
I was just gonna post the same thing @erikdstock! Can this be rolled up in the mutation query itself, in one quick fragment spread in the response?
(these days its rare to have to mutate the store manually)
There was a problem hiding this comment.
This code looks quite complex and hard to understand, and it seems like it could break very easily, which would break the entire dismiss logic in the component.
I would vote for either keeping it simple (like the initial not-100%-ideal solution with useState) or trying to make it work with a fragment spread.
There was a problem hiding this comment.
I agree with this being not easy to ready, I'll try spreading the fragment in the query and see what happens :)
|
I'll pause the work on this since it needs some work on MP, and the current implementation has the |
MrSltun
changed the title
This PR resolves []
Description
This PR is a follow-up on #10961
This PR updates the way we update the tasks list to utilize the Relay store
This change uses the Relay mutation
updaterfunction to remove a node from the tasks list if the dismiss/acknowledge mutation was successfulPR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.