feat: focus input on search tab tap #11169
Open
+64
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MounirDhahri
force-pushed
the
feat/focus-search-input-on-search-tap
branch
from
f43879c to
a0a096b
Compare
MounirDhahri
force-pushed
the
feat/focus-search-input-on-search-tap
branch
from
5b71ff2 to
c34ce13
Compare
MounirDhahri
commented
Dec 12, 2024
| ) | ||
| useImperativeHandle(ref, () => ({ | ||
| focus: () => { | ||
| if (!debouncedIsVisible.debouncedValue) { |
There was a problem hiding this comment.
Here, I am debouncing the value to make sure I don't end up opening the modal again after dismissing it.
MounirDhahri
force-pushed
the
feat/focus-search-input-on-search-tap
branch
from
c34ce13 to
b972158
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to focus on the search bar and to dismiss it after tab bar press.
Screen.Recording.2024-12-12.at.15.43.14.mov
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.