-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump react-native from 0.73.10 to 0.75.4 #10995
Conversation
… citypicker Co-authored-by: Brian Beckerle <[email protected]>
5e6b6cd
to
551832f
Compare
postNotificationName: noop("postNotificationName"), | ||
didFinishBootstrapping: () => null, | ||
reactStateUpdated: () => null, | ||
getConstants: () => ({}), | ||
getConstants: () => null as any, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went with this as it was in line 130 to avoid solving extra type issues but it is not ideal
ios-8.56.0-2024.11.07.09 android-8.56.0-1674645923 |
ios/Artsy/Emission/ViewControllers/ARMapComponentViewController.m
Outdated
Show resolved
Hide resolved
ios/Artsy/Emission/ViewControllers/ARMapContainerViewController.m
Outdated
Show resolved
Hide resolved
Co-authored-by: Brian Beckerle <[email protected]>
Co-authored-by: Brian Beckerle <[email protected]>
@@ -587,6 +587,9 @@ export class GlobalMap extends React.Component<Props, State> { | |||
{...mapProps} | |||
onRegionIsChanging={this.onRegionIsChanging} | |||
onDidFinishRenderingMapFully={this.onDidFinishRenderingMapFully} | |||
attributionEnabled | |||
logoEnabled | |||
logoPosition={{ bottom: 150, left: 10 }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Brian Beckerle <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good! Awesome work! thanks for pushing through!
Impressive effort 👏👏👏 |
@rnmapbox/mapsAuthor: React Native Mapbox Team Description: A Mapbox react native module for creating custom maps Homepage: https://github.com/rnmapbox/maps#readme
|
A community-supported, open-source React Native library for building maps with the Mapbox Maps SDK for iOS and Mapbox Maps SDK for Android
News & Discussions
→ Call for additional maintainers discussion thread
Supported Implementations
At the moment we support Mapbox (v10) and Mapbox (v11) beta.
We default to Mapbox (v10).
See iOS & Android setup guide for using v11 beta
Prerequisite
- Please Sign Up to Mapbox to get the Mapbox Access Token.
Dependencies
- node
- npm
- React Native (0.70+, older versions from 0.64+ might or might not work)
Installation
Check our Installation instructions
Getting Started
For more information, check out our Getting Started section
Run Project
Before you run your project be sure you have completed the Installation Guides for Android or iOS.
Run iOS Simulator
# Run with yarn
yarn run ios
# or Run with NPM
npm run ios
Run Android Emulator
# Run with yarn
yarn run android
# or Run with NPM
npm run android
Adding a map
import React from 'react';
import { StyleSheet, View } from 'react-native';
import Mapbox from '@rnmapbox/maps';
Mapbox.setAccessToken('<YOUR_ACCESSTOKEN>');
const App = () => {
return (
<View style={styles.page}>
<View style={styles.container}>
<Mapbox.MapView style={styles.map} />
</View>
</View>
);
}
export default App;
const styles = StyleSheet.create({
page: {
flex: 1,
justifyContent: 'center',
alignItems: 'center',
},
container: {
height: 300,
width: 300,
},
map: {
flex: 1
}
});
Documentation
Components
- MapView
- StyleImport
- Light
- StyleSheet
- PointAnnotation
- MarkerView
- Callout
- Camera
- UserLocation
- LocationPuck
- Images
- Image
- Models
Sources
Layers
- BackgroundLayer
- CircleLayer
- FillExtrusionLayer
- FillLayer
- LineLayer
- RasterLayer
- SymbolLayer
- HeatmapLayer
- SkyLayer
- ModelLayer
Terrain
Offline
Misc
Expo Support
This package is not available in the Expo Go app. Learn how you can use it with custom dev clients.
Testing with Jest
This library provides some mocks which are necessary for running tests.
Example:
"jest": {
"preset": "react-native",
"setupFilesAfterEnv": ["@rnmapbox/maps/setup-jest"],
"transformIgnorePatterns": [
"node_modules/(?!(...|@rnmapbox))"
]
}
Sponsors
Help drive this repo forward - be a sponsor. Add a comment here to discuss your sponsorship.
Terrain Dance |
Developer Group
Have a question or need some help? Use Github discussions or the react-native channel in the mapbox discord.
New dependencies added: @rnmapbox/maps
.
This PR resolves PHIRE-1275
Description
Bumps
react-native
version from0.73.10
to0.75.4
.Removed Patches:
Bumped Dependencies:
@gorhom/bottom-sheet
@react-native-async-storage/async-storage
"@react-native-mapbox-gl/maps": "8.5.0"
removed in favor of"@rnmapbox/maps": "10.1.31",
@shopify/flash-list
@stripe/stripe-react-native
moti
react-native-reanimated
Removed Dependencies:
Flipper related stuff and react devtools (the react dev tools are still acessible with
npx react-devtools
"deprecated-react-native-prop-types": "4.1.0",
"react-devtools-core"
"rn-flipper-async-storage-advanced": "1.0.5",
"redux-flipper": "2.0.2",
"react-native-flipper": "0.265.0",
"react-native-flipper-performance-plugin": "0.4.0",
"react-native-flipper-relay-devtools": "1.0.3",
Important
Flipper is decoupled from react native - we will run a survey to see if we need to bring it back or not
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.