Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump react-native from 0.73.10 to 0.75.4 #10995

Merged
merged 40 commits into from
Nov 12, 2024

Conversation

gkartalis
Copy link
Member

@gkartalis gkartalis commented Oct 23, 2024

This PR resolves PHIRE-1275

Description

Bumps react-native version from 0.73.10 to 0.75.4.

Removed Patches:

  • react-native-mapbox-gl/maps
  • react-native
  • deprecated-react-native-prop-types dep (included in the react native patch)

Bumped Dependencies:

  • @gorhom/bottom-sheet
  • @react-native-async-storage/async-storage
  • "@react-native-mapbox-gl/maps": "8.5.0" removed in favor of "@rnmapbox/maps": "10.1.31",
  • @shopify/flash-list
  • @stripe/stripe-react-native
  • moti
  • react-native-reanimated

Removed Dependencies:

Flipper related stuff and react devtools (the react dev tools are still acessible with npx react-devtools

  • "deprecated-react-native-prop-types": "4.1.0",
  • "react-devtools-core"
  • "rn-flipper-async-storage-advanced": "1.0.5",
  • "redux-flipper": "2.0.2",
  • "react-native-flipper": "0.265.0",
  • "react-native-flipper-performance-plugin": "0.4.0",
  • "react-native-flipper-relay-devtools": "1.0.3",

Important

Flipper is decoupled from react native - we will run a survey to see if we need to bring it back or not

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • bump react-native version

Need help with something? Have a look at our docs, or get in touch with us.

@gkartalis gkartalis self-assigned this Oct 23, 2024
@gkartalis gkartalis changed the title build(deps): bump rn 74 build(deps): bump react-native from 0.73.10 to 0.75.4 Oct 31, 2024
@gkartalis gkartalis force-pushed the gkartalis/bump-rn-74 branch from 5e6b6cd to 551832f Compare November 5, 2024 07:20
postNotificationName: noop("postNotificationName"),
didFinishBootstrapping: () => null,
reactStateUpdated: () => null,
getConstants: () => ({}),
getConstants: () => null as any,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went with this as it was in line 130 to avoid solving extra type issues but it is not ideal

@gkartalis
Copy link
Member Author

ios-8.56.0-2024.11.07.09

android-8.56.0-1674645923

HACKS.md Show resolved Hide resolved
@@ -587,6 +587,9 @@ export class GlobalMap extends React.Component<Props, State> {
{...mapProps}
onRegionIsChanging={this.onRegionIsChanging}
onDidFinishRenderingMapFully={this.onDidFinishRenderingMapFully}
attributionEnabled
logoEnabled
logoPosition={{ bottom: 150, left: 10 }}
Copy link
Member Author

@gkartalis gkartalis Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gkartalis gkartalis marked this pull request as ready for review November 11, 2024 15:20
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Nov 11, 2024

This PR contains the following changes:

  • Dev changes (bump react-native version - gkartalis)

Generated by 🚫 dangerJS against 5346646

Copy link
Contributor

@brainbicycle brainbicycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good! Awesome work! thanks for pushing through!

@gkartalis gkartalis merged commit 58f8e9d into main Nov 12, 2024
7 checks passed
@gkartalis gkartalis deleted the gkartalis/bump-rn-74 branch November 12, 2024 09:20
@MounirDhahri
Copy link
Member

Impressive effort 👏👏👏

@artsy-peril
Copy link
Contributor

artsy-peril bot commented Dec 11, 2024

@rnmapbox/maps

Author: React Native Mapbox Team

Description: A Mapbox react native module for creating custom maps

Homepage: https://github.com/rnmapbox/maps#readme

Createdover 2 years ago
Last Updatedabout 1 month ago
LicenseMIT
Maintainers1
Releases180
Direct Dependencies@turf/along, @turf/distance, @turf/helpers, @turf/length, @turf/nearest-point-on-line, @types/geojson and debounce
Keywordsgl, ios, android, mapbox and react-native
README

Mapbox Maps SDK for React Native

npm version iOS & Android Build

A community-supported, open-source React Native library for building maps with the Mapbox Maps SDK for iOS and Mapbox Maps SDK for Android


News & Discussions

Call for additional maintainers discussion thread



Supported Implementations

At the moment we support Mapbox (v10) and Mapbox (v11) beta.
We default to Mapbox (v10).

See iOS & Android setup guide for using v11 beta

Prerequisite

  1. Please Sign Up to Mapbox to get the Mapbox Access Token.

Dependencies

Installation

Check our Installation instructions

Getting Started

For more information, check out our Getting Started section

Run Project

Before you run your project be sure you have completed the Installation Guides for Android or iOS.

Run iOS Simulator

# Run with yarn
yarn run ios

# or Run with NPM
npm run ios

Run Android Emulator

# Run with yarn
yarn run android

# or Run with NPM
npm run android

Adding a map

import React from 'react';
import { StyleSheet, View } from 'react-native';
import Mapbox from '@rnmapbox/maps';

Mapbox.setAccessToken('<YOUR_ACCESSTOKEN>');

const App = () => {
  return (
    <View style={styles.page}>
      <View style={styles.container}>
        <Mapbox.MapView style={styles.map} />
      </View>
    </View>
  );
}

export default App;

const styles = StyleSheet.create({
  page: {
    flex: 1,
    justifyContent: 'center',
    alignItems: 'center',
  },
  container: {
    height: 300,
    width: 300,
  },
  map: {
    flex: 1
  }
});

Documentation

Components

Sources

Layers

Terrain

Offline

Misc

Expo Support

This package is not available in the Expo Go app. Learn how you can use it with custom dev clients.

Testing with Jest

This library provides some mocks which are necessary for running tests.

Example:

"jest": {
  "preset": "react-native",
  "setupFilesAfterEnv": ["@rnmapbox/maps/setup-jest"],
  "transformIgnorePatterns": [
      "node_modules/(?!(...|@rnmapbox))"
  ]
}

Sponsors

Help drive this repo forward - be a sponsor. Add a comment here to discuss your sponsorship.

Scout To Hunt Terrain Dance LLC

Scout To Hunt

Terrain Dance

Developer Group

Have a question or need some help? Use Github discussions or the react-native channel in the mapbox discord.

New dependencies added: @rnmapbox/maps.

Generated by 🚫 dangerJS against 5346646

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants