-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor navigation infra #10977
Merged
Merged
Changes from all commits
Commits
Show all changes
85 commits
Select commit
Hold shift + click to select a range
51de304
chore: add feature flag
MounirDhahri 6f5ab1d
feat: prepare main stack
MounirDhahri c9919ce
feat: add tabs stack
MounirDhahri 356284c
feat: hook up the different screens
MounirDhahri fbd6049
feat: update other navigate methods to support new navigation infra
MounirDhahri 7a30028
chore: add hides back button to tabs
MounirDhahri 2bd3d73
feat: update tabs styling
MounirDhahri 0b2c983
chore: remove console.log
MounirDhahri 55a927d
chore: update live sale logic
MounirDhahri a44176f
chore: remove unused prop
MounirDhahri 58220e8
feat: remove tab screens from shared routes
MounirDhahri b7166d4
chore: remove comment
MounirDhahri 4e0e226
chore: update screen wrapper props
MounirDhahri d03ce95
feat: add tab screens to the individual tabs
MounirDhahri 147123c
chore: add todo comment
MounirDhahri c93bb39
fix: imports on Tabs.tsx
MounirDhahri b263762
fix: ts
MounirDhahri afef924
fix: borken types for tabs
MounirDhahri 5e07a05
feat: support switchTab
MounirDhahri b4f77b2
fix: add missing isNavigationReady to deep linking 💣🚨
MounirDhahri 335a19e
chore: hide relay logs when metaflag is disabled
MounirDhahri 12db5c5
chore: better types (thanks Carlos)
MounirDhahri 05dd8f3
feat/fix: register native module
MounirDhahri 9d01c7b
chore: improve presentation of dev settings
MounirDhahri 976df6d
feat: default navigation header and other UI fixes
MounirDhahri 98978f7
chore(side-quest): improve OTP UX
MounirDhahri 72da53a
feat: add new patterns example on dev menu
MounirDhahri a83a51f
chore: better directories
MounirDhahri 46ff305
fix: more UX fixes
MounirDhahri d7d7061
chore: better DX
MounirDhahri 28b0701
feat: add staging indicator
MounirDhahri e5a458a
fix: more UI fixes for headers
MounirDhahri ebd04a7
chore: better bottom tabs hiding logic
MounirDhahri 4d2c215
fix: more UI issues
MounirDhahri 8d0debf
fix: consignment inquiry UI issues
MounirDhahri 62d4d92
chore: decouple fetch profile
MounirDhahri 002d1a5
fix: more broken paddings
MounirDhahri 2d1617e
fix: patch broken react-native-screens
MounirDhahri 6695400
fix: more screen header issues
MounirDhahri a55447e
fix: more navigation issues
MounirDhahri d8cfac2
fix: UI issues on the Inbox
MounirDhahri 73db165
chore: extract spinner
MounirDhahri 3df7e58
feat: better bottom tabs
MounirDhahri c41302f
chore: bring back tab button count
MounirDhahri 46f19f3
fix: broken tests
MounirDhahri 51918ff
fix: more broken UI
MounirDhahri 186dbbc
fix: more tests
MounirDhahri d05e39d
fix: skip migrations test TODO: To be fixed later
MounirDhahri 26d0216
fix: more fixes to the dev menu
MounirDhahri fc3ab7d
chore: align staging indicator
MounirDhahri ed4aece
fix: broken tests
MounirDhahri ea42143
chore: minor UI fixes
MounirDhahri ddc5c63
chore: refactor - make routes a variable instead of a function
MounirDhahri a823bd8
fix: old navigation headers logic
MounirDhahri 074866d
chore: remove hack
MounirDhahri 2c1df7a
chore: self review [round 1]
MounirDhahri 566d0ed
fix: more broken tests
MounirDhahri f4088b7
chore: better nav stack logic
MounirDhahri 4ae9f09
fix: remove patch
MounirDhahri ccd12f4
fix: city guide missing back button
MounirDhahri 7db306a
fix: remove post-install
MounirDhahri 524b401
chore: address review comments
MounirDhahri 5260e1a
Merge branch 'main' into feat/update-navigation-infra
MounirDhahri 3b793e1
fix: make inbox full bleed
MounirDhahri e5a6a9e
feat: support replace
MounirDhahri e40dec5
feat: support only show in tab name
MounirDhahri b7f1662
fix: minor tweaks
MounirDhahri 6d90c40
chore: bring back state change instrumentation
MounirDhahri 5f2c1aa
chore: bring back tap on search to focus
MounirDhahri 4cb2960
fix: align simple page with header with current designs
MounirDhahri 9443609
fix: align text title on android
MounirDhahri fc25b84
Revert "fix: align simple page with header with current designs"
MounirDhahri 09b8c43
fix: align (again) simple page with header with current designs
MounirDhahri 7c3360d
fix: annoying spinner on add artwork to my collection
MounirDhahri 1a46ab4
feat: introduce new modal stack
MounirDhahri 09d5495
fix: auction bidding modal
MounirDhahri 0543d87
fix: make sure privacy and terms are displayed in modals
MounirDhahri 64cc549
fix: typescript
MounirDhahri a101cbc
Merge branch 'main' into feat/update-navigation-infra
MounirDhahri bbb9ae7
fix: broken test
MounirDhahri 26601ad
Merge branch 'main' into feat/update-navigation-infra
MounirDhahri 961d64f
Merge branch 'main' into feat/update-navigation-infra
MounirDhahri 7cdd53e
fix: address review comments
MounirDhahri 834e38b
fix: skip not needed broken test
MounirDhahri 1946117
fix: bring back old presentation of screens in app registry
MounirDhahri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, we are on
App.tsx
. This is our entry point to the app (both Android and iOS).In order to make sure we don't break old logic, I will have the new navigation shell within a separate container.
This choice will also allow us to take advantage of the existing hooks and providers that we already set up in this file.
What does this commit do?
In this commit, we are following the best practices from react-navigation around authentication flows [link].
[Go back] ⬅️_____________ ➡️ [Preparing the tab stack]