Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(EMI-2095): Add Swipeable component #10879

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

MrSltun
Copy link
Member

@MrSltun MrSltun commented Oct 1, 2024

This PR resolves EMI-2095

Note

This PR is related to artsy/palette-mobile#263, we decided for the time being to move the work to Eigen.
More info in the Slack thread 🔒

Description

This PR adds a swipeable component to Eigen

Demos (from Palette-Mobile)

Android iOS
swipeable-android.mov
swipeable-ios.mov

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • Add swipeable component to Eigen - mrsltun

Need help with something? Have a look at our docs, or get in touch with us.

araujobarret
araujobarret previously approved these changes Oct 1, 2024
nickskalkin
nickskalkin previously approved these changes Oct 2, 2024
Copy link
Contributor

@nickskalkin nickskalkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@olerichter00 olerichter00 dismissed stale reviews from nickskalkin and araujobarret via d6f27e0 October 7, 2024 07:54
@olerichter00 olerichter00 added the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label Oct 7, 2024
@olerichter00 olerichter00 merged commit ac0522f into main Oct 7, 2024
1 of 5 checks passed
@olerichter00 olerichter00 deleted the mrsltun/EMI-2095/create-swipable-container branch October 7, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jira Synced Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants