fix(APPLAUSE-6697021): auth2 back button double tap crash (#11309)

* fix(APPLAUSE-6697021): auth2 back button double click crash * undid change to ios/Podfile.lock
artsy · Dec 18, 2024 · b04e407 · b04e407
1 parent 1d1f97e
commit b04e407
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/app/Scenes/Onboarding/Auth2/AuthContext.tsx b/src/app/Scenes/Onboarding/Auth2/AuthContext.tsx
@@ -38,7 +38,9 @@ export const defaultState: AuthContextModel = {
 
   // actions
   goBack: action((state) => {
-    state.currentScreen = state.previousScreens.pop()
+    if (state.previousScreens.length !== 0) {
+      state.currentScreen = state.previousScreens.pop()
+    }
   }),
   setCurrentScreen: action((state, currentScreen) => {
     state.previousScreens.push(state.currentScreen)

diff --git a/src/app/Scenes/Onboarding/Auth2/__tests__/AuthContext.tests.tsx b/src/app/Scenes/Onboarding/Auth2/__tests__/AuthContext.tests.tsx
@@ -57,6 +57,17 @@ describe("AuthContext", () => {
       expect(getState().currentScreen).toEqual({ name: "SignUpPasswordStep" })
     })
 
+    it("doesn't goBack when there are no previous screens", () => {
+      const { getState, actions } = setup({
+        currentScreen: { name: "LoginWelcomeStep" },
+        previousScreens: [],
+      })
+
+      act(() => actions.goBack())
+
+      expect(getState().currentScreen).toEqual({ name: "LoginWelcomeStep" })
+    })
+
     it("setCurrentScreen", () => {
       const { getState, actions } = setup({ currentScreen: { name: "LoginWelcomeStep" } })