fix: remove @Cacheable from non cacheable requests (#11070)

artsy · Nov 8, 2024 · a417403 · a417403
1 parent 2b3d7e7
commit a417403
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/src/app/Scenes/Artist/Artist.tsx b/src/app/Scenes/Artist/Artist.tsx
@@ -199,7 +199,7 @@ interface ArtistQueryRendererProps {
 }
 
 export const ArtistScreenQuery = graphql`
-  query ArtistAboveTheFoldQuery($artistID: String!, $input: FilterArtworksInput) @cacheable {
+  query ArtistAboveTheFoldQuery($artistID: String!, $input: FilterArtworksInput) {
     artist(id: $artistID) @principalField {
       ...ArtistHeader_artist
       ...ArtistArtworks_artist @arguments(input: $input)

diff --git a/src/app/Scenes/HomeView/HomeView.tsx b/src/app/Scenes/HomeView/HomeView.tsx
@@ -211,7 +211,7 @@ const sectionsFragment = graphql`
 `
 
 export const homeViewScreenQuery = graphql`
-  query HomeViewQuery($count: Int!, $cursor: String) @cacheable {
+  query HomeViewQuery($count: Int!, $cursor: String) {
     homeView {
       experiments {
         name

diff --git a/src/app/Scenes/HomeView/Sections/HomeViewSectionSales.tsx b/src/app/Scenes/HomeView/Sections/HomeViewSectionSales.tsx
@@ -202,7 +202,7 @@ const HomeViewSectionSalesPlaceholder: React.FC<FlexProps> = (flexProps) => {
 }
 
 const homeViewSectionSalesQuery = graphql`
-  query HomeViewSectionSalesQuery($id: String!) @cacheable {
+  query HomeViewSectionSalesQuery($id: String!) {
     homeView {
       section(id: $id) {
         ...HomeViewSectionSales_section

diff --git a/src/app/Scenes/HomeView/Sections/HomeViewSectionShows.tsx b/src/app/Scenes/HomeView/Sections/HomeViewSectionShows.tsx
@@ -70,7 +70,7 @@ const HomeViewSectionShowsPlaceholder: React.FC<FlexProps> = (flexProps) => {
 }
 
 const homeViewSectionShowsQuery = graphql`
-  query HomeViewSectionShowsQuery($id: String!) @cacheable {
+  query HomeViewSectionShowsQuery($id: String!) {
     homeView {
       section(id: $id) {
         ...HomeViewSectionShows_section

diff --git a/src/app/Scenes/Partner/Partner.tsx b/src/app/Scenes/Partner/Partner.tsx
@@ -152,7 +152,7 @@ export const PartnerQueryRenderer: React.FC<{
     <QueryRenderer<PartnerQuery>
       environment={getRelayEnvironment()}
       query={graphql`
-        query PartnerQuery($partnerID: String!) @cacheable {
+        query PartnerQuery($partnerID: String!) {
           partner(id: $partnerID) {
             ...Partner_partner
           }

diff --git a/src/app/system/relay/helpers/cacheHeaderMiddlewareHelpers.ts b/src/app/system/relay/helpers/cacheHeaderMiddlewareHelpers.ts
@@ -26,7 +26,7 @@ export const hasNoCacheParamPresent = (url: string) => {
   return false
 }
 
-export const SKIP_CACHE_ARGUMENTS = ["includeArtworksByFollowedArtists"]
+export const SKIP_CACHE_ARGUMENTS = ["includeArtworksByFollowedArtists", "isFollowed", "isSaved"]
 // Important - Add any new personalized argument checks to this list. That way, logged-in queries
 // _without_ this argument can still be `@cacheable`, and when queries include this argument,
 // those queries will not be cached.