fix: auth2 QA omnibus (#11080)

* fix: auth2 QA omnibus * puts the useAndroidStatusBarColor hook back * removes clear button from social linking password field
artsy · Nov 8, 2024 · 253cadf · 253cadf
1 parent 5deadbd
commit 253cadf
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 5 deletions.
diff --git a/src/app/Scenes/Onboarding/Auth2/AuthApp.tsx b/src/app/Scenes/Onboarding/Auth2/AuthApp.tsx
@@ -4,9 +4,11 @@ import { AuthScenes } from "app/Scenes/Onboarding/Auth2/AuthScenes"
 import { AuthBackground } from "app/Scenes/Onboarding/Auth2/components/AuthBackground"
 import { AuthModal } from "app/Scenes/Onboarding/Auth2/components/AuthModal"
 import { useAndroidStatusBarColor } from "app/Scenes/Onboarding/Auth2/hooks/useAndroidStatusBarColor"
+import { useSwitchStatusBarStyle } from "app/utils/useStatusBarStyle"
 import React from "react"
 
 export const AuthApp: React.FC = () => {
+  useSwitchStatusBarStyle("light-content", "dark-content")
   useAndroidStatusBarColor()
 
   return (

diff --git a/src/app/Scenes/Onboarding/Auth2/scenes/LoginOTPStep.tsx b/src/app/Scenes/Onboarding/Auth2/scenes/LoginOTPStep.tsx
@@ -89,6 +89,7 @@ export const LoginOTPStep: React.FC = () => {
           <Input
             autoCapitalize="none"
             autoComplete="one-time-code"
+            importantForAutofill="yes"
             autoCorrect={false}
             blurOnSubmit={false}
             error={errors.otp}
@@ -103,7 +104,6 @@ export const LoginOTPStep: React.FC = () => {
             returnKeyType="done"
             title={codeType === "authentication" ? "Authentication code" : "Recovery code"}
             value={values.otp}
-            textContentType="oneTimeCode"
             onChangeText={(text) => {
               handleChange("otp")(text)
             }}

diff --git a/src/app/Scenes/Onboarding/Auth2/scenes/LoginPasswordStep.tsx b/src/app/Scenes/Onboarding/Auth2/scenes/LoginPasswordStep.tsx
@@ -121,14 +121,14 @@ const LoginPasswordStepForm: React.FC = () => {
       <Input
         autoCapitalize="none"
         autoComplete="password"
+        importantForAutofill="yes"
         autoCorrect={false}
         blurOnSubmit={false}
         error={submitCount > 0 ? errors.password : undefined}
         placeholderTextColor={color("black30")}
         ref={passwordRef}
         returnKeyType="done"
         secureTextEntry
-        textContentType="password"
         testID="password"
         title="Password"
         value={values.password}

diff --git a/src/app/Scenes/Onboarding/Auth2/scenes/LoginWelcomeStep.tsx b/src/app/Scenes/Onboarding/Auth2/scenes/LoginWelcomeStep.tsx
@@ -128,14 +128,14 @@ const LoginWelcomeStepForm: React.FC = () => {
 
       <Input
         autoCapitalize="none"
-        autoComplete="email"
+        autoComplete="username"
+        importantForAutofill="yes"
         autoCorrect={false}
         blurOnSubmit={false}
         placeholderTextColor={color("black30")}
         ref={emailRef}
         spellCheck={false}
         keyboardType="email-address"
-        textContentType="username"
         returnKeyType="next"
         title="Email"
         value={values.email}

diff --git a/src/app/Scenes/Onboarding/OnboardingSocialLink.tsx b/src/app/Scenes/Onboarding/OnboardingSocialLink.tsx
@@ -189,7 +189,6 @@ export const OnboardingSocialLink: React.FC<
               }}
               onSubmitEditing={handleSubmit}
               blurOnSubmit={false}
-              clearButtonMode="while-editing"
               placeholder="Password"
               returnKeyType="go"
               textContentType="password"