Skip to content

Commit

Permalink
fix(deeplinks): fix deeplinks from killed state on iOS 17 (#11241)
Browse files Browse the repository at this point in the history
make didFinishBootstrapping true only once nav is ready
  • Loading branch information
brainbicycle authored Dec 4, 2024
1 parent 73b4214 commit 0fc3996
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions src/app/Navigation/Navigation.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { createNativeStackNavigator } from "@react-navigation/native-stack"
import { addBreadcrumb } from "@sentry/react-native"
import { FPSCounter } from "app/Components/FPSCounter"
import { LoadingSpinner } from "app/Components/Modals/LoadingModal"
import { LegacyNativeModules } from "app/NativeModules/LegacyNativeModules"
import {
AuthenticatedRoutes,
AuthenticatedRoutesParams,
Expand Down Expand Up @@ -59,6 +60,7 @@ export const Navigation = () => {
routingInstrumentation.registerNavigationContainer(internal_navigationRef)

setNavigationReady({ isNavigationReady: true })
LegacyNativeModules.ARNotificationsManager.didFinishBootstrapping()

if (trackSiftAndroid) {
const initialRouteName = internal_navigationRef?.current?.getCurrentRoute()?.name
Expand Down
1 change: 0 additions & 1 deletion src/app/store/GlobalStoreModel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ export const getGlobalStoreModel = (): GlobalStoreModel => ({
(actions) => actions.rehydrate,
() => {
LegacyNativeModules.ARNotificationsManager.reactStateUpdated(unsafe__getEnvironment())
LegacyNativeModules.ARNotificationsManager.didFinishBootstrapping()
}
),
sessionState: {
Expand Down
1 change: 1 addition & 0 deletions src/app/system/navigation/ModalStack.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ export const ModalStack: React.FC = ({ children }) => {
routingInstrumentation.registerNavigationContainer(__unsafe_mainModalStackRef)

setNavigationReady({ isNavigationReady: true })
LegacyNativeModules.ARNotificationsManager.didFinishBootstrapping()

if (trackSiftAndroid) {
const initialRouteName = __unsafe_mainModalStackRef?.current?.getCurrentRoute()?.name
Expand Down

0 comments on commit 0fc3996

Please sign in to comment.