This repository has been archived by the owner on Jan 4, 2023. It is now read-only.
Swift 3 Update #617
Merged
Swift 3 Update #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Okay, down to 22 failing tests, 19 of which are snapshot tests. |
|
Cool 👍 |
ashfurrow
commented
Oct 25, 2016
| } | ||
| } | ||
|
|
||
| func showConditionsOfSaleCommand() -> CocoaAction { | ||
| return CocoaAction { _ in | ||
| self.hideAllTheThings().then(self.showWebController("https://artsy.net/conditions-of-sale")) | ||
| self.hideAllTheThings().then(self.showWebController(address: "https://artsy.net/conditions-of-sale")) |
There was a problem hiding this comment.
So the hideAllTheThings() observables is dismissing the fulfillment nav controller, which ultimately causes the button who owns this action to be deallocated, and the Action gets deallocated, and the subscription to this observable chain gets disposed of before the web controller has been presented. Yikes.
…o swift-3-update
|
Doing one last on-device check before we merge 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix "Use Artsy Login Details" -> "Use Artsy Bidder Details" problem.(Opened Login Loop #621 )Storyboard ID updateOutbid flow cannot be cancelled or something is wrong with bidding via artsy credentialsFixes #619.