chore: Upgrade to Ruby 3.1 #1548
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonallured
changed the title
jonallured
force-pushed
the
jonallured/chore-upgrade-to-ruby-three-one
branch
from
753d73b to
bf91df4
Compare
|
Hi!!! I think we might need to bump selenium-webdrivers version here too This is a very helpful PR! https://github.com/artsy/volt/pull/7459/files |
jonallured
force-pushed
the
jonallured/chore-upgrade-to-ruby-three-one
branch
2 times, most recently
from
3822e99 to
70c95b0
Compare
jpotts244
reviewed
Dec 5, 2024
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| require "rails/all" | |||
| require_relative "../lib/jwt_middleware" | |||
| require "ostruct" | |||
|
|
|||
There was a problem hiding this comment.
Ok you got me - that's probably a symptom of something else but it fixed a bunch of these errors:
NameError:
uninitialized constant GraphQL::Compatibility::ExecutionSpecification::SpecificationSchema::OpenStruct
There was a problem hiding this comment.
Im laughing at ruby/removing this from the core library - its everywhere
jonallured
force-pushed
the
jonallured/chore-upgrade-to-ruby-three-one
branch
from
70c95b0 to
43481c7
Compare
jonallured
force-pushed
the
jonallured/chore-upgrade-to-ruby-three-one
branch
from
43481c7 to
358ae8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pursuant to our pattern of upgrading Ruby and then Rails this PR does the Ruby 3.1 upgrade in preparation for Rails 7.0. I had to upgrade Standard Ruby and also add a gem called "matrix" to the Gemfile which wasn't something I had bumped into before. 🤷
/cc @artsy/amber-devs