Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AS-4428] Adding event to track list privacy #485

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

daytavares
Copy link
Contributor

@daytavares daytavares commented Mar 15, 2024

The type of this PR is: TYPE

This PR resolves [AS-4428]

Description

PR Checklist (tick all before merging)

  • If I've added a new file to the tree I've exported it from the common index.ts
  • I've added comments with examples for any new interfaces and ensured that they're in the docs
  • No platform-specific terminology has been used outside of click and tap (platform is inferred by the DB storing events)

@daytavares daytavares requested a review from starsirius March 15, 2024 15:16
@daytavares daytavares self-assigned this Mar 15, 2024
@artsy-peril artsy-peril bot added Jira Synced Indicates that Peril has connected this PR to Jira Version: Minor A deploy for new features labels Mar 15, 2024
/**
* User clicks on the toggle to edit artworks list privacy
*
* This schema describes events sent to Segment from [[editedArtworkListPrivacy]]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daytavares The current design requires clicking the "Save Changes" button to save the list privacy update. It means:

  • When collector toggles the list privacy for individual list, nothing is really saved, until clicking the "Save Changes" button. And it's possible that collector can toggle the privacy, dismiss the modal, and does not save the changes.
  • When clicking "Save Changes", we'll update the list privacy for all lists in a batch.

So I want to double check that

  • The event would only be sent when collector clicks "Save Changes", and would not be sent when collector toggles the privacy for individual list.
  • We'll fire x number of events when collector saves the changes, with x being the total number of lists.
    • I wonder if it's better to just fire 1 event, with all the list privacy value in an array or something.

Let me know if I can pair and clarify things together!

@daytavares
Copy link
Contributor Author

@starsirius can we merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jira Synced Indicates that Peril has connected this PR to Jira Version: Minor A deploy for new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants