Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install autoconf 2.69 by default #427

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iskounen
Copy link
Contributor

This PR updates the APRd setup script to install autoconf 2.69 by default. It currently only does it for a specific version of macOS (10.14.6), but I have needed to perform this step manually in subsequent versions as well.

An alternative approach would be to use is-at-least, but I think that is only available for Zsh:

is-at-least "10.14.6" "$(sw_vers -productVersion)"

@iskounen iskounen requested review from starsirius and artsyjian June 26, 2023 14:12
@iskounen iskounen self-assigned this Jun 26, 2023
Copy link
Member

@starsirius starsirius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need that specific 2.69 version? If so, maybe we can add a comment about it!

Copy link
Member

@starsirius starsirius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need that specific 2.69 version? If so, maybe we can add a comment about it!

@iskounen
Copy link
Contributor Author

Yeah, I can put the comment back in and make it more general (ie. not specific to Mojave)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants