Added other dependencies and clarification about HF models #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix cases where non-standard llama model path names gets bypassed in tokenizer check. The tokenizer is init with use_fast=True and qlora requires >4.29.2 transformers so the only possible tokenizer is LlamaTokenizerFast.
Shevilll
approved these changes
May 26, 2023
Fixes a copy paste error where per_device_train_batch_size was set twice.
Check for LlamaTokenizerFast rather than infer type from path name.
Fix link to inference notebook
Set per_device_eval_batch_size in finetune.sh
artidoro
requested changes
May 28, 2023
README.md
Outdated
| @@ -37,11 +37,12 @@ pip install -q -U bitsandbytes | |||
| pip install -q -U git+https://github.com/huggingface/transformers.git | |||
| pip install -q -U git+https://github.com/huggingface/peft.git | |||
| pip install -q -U git+https://github.com/huggingface/accelerate.git | |||
| pip install -U datasets evaluate scipy nltk | |||
There was a problem hiding this comment.
I think these might change. It would be better to put these in a requirements.txt file. Also, note that we removed the nltk dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to run the fine tuning example, I noticed this library needs some additional dependencies not mentioned in the README