Apply fixes from StyleCI

arthurpar06 · Mar 4, 2024 · fada835 · fada835
1 parent 1906a61
commit fada835
Show file tree

Hide file tree

Showing 36 changed files with 146 additions and 166 deletions.
diff --git a/app/Console/Commands/CreateConfigs.php b/app/Console/Commands/CreateConfigs.php
@@ -5,8 +5,6 @@
 use App\Contracts\Command;
 use App\Services\Installer\ConfigService;
 use App\Services\Installer\MigrationService;
-use App\Services\Installer\SeederService;
-use DatabaseSeeder;
 use Illuminate\Support\Facades\App;
 
 /**

diff --git a/app/Contracts/Command.php b/app/Contracts/Command.php
@@ -4,10 +4,6 @@
 
 use Illuminate\Log\Logger;
 use Illuminate\Support\Facades\Log;
-use Symfony\Component\Console\Output\OutputInterface;
-use Symfony\Component\Process\Process;
-
-use function is_array;
 
 /**
  * Class BaseCommand

diff --git a/app/Contracts/Repository.php b/app/Contracts/Repository.php
@@ -94,10 +94,10 @@ public function whereOrder($where, $sort_by, $order_by = 'asc')
     /**
      * Find records where values don't match a list but sort the rest
      *
-     * @param string $col
-     * @param array  $values
+     * @param string       $col
+     * @param array        $values
      * @param string|array $sort_by
-     * @param string $order_by
+     * @param string       $order_by
      *
      * @return $this
      */

diff --git a/app/Exceptions/AssetNotFound.php b/app/Exceptions/AssetNotFound.php
@@ -6,7 +6,8 @@
 
 class AssetNotFound extends AbstractHttpException
 {
-    public function __construct(Exception $exception) {
+    public function __construct(Exception $exception)
+    {
         parent::__construct(
             404,
             $exception->getMessage()

diff --git a/app/Http/Controllers/Admin/ExpenseController.php b/app/Http/Controllers/Admin/ExpenseController.php
@@ -11,7 +11,6 @@
 use App\Repositories\AirlineRepository;
 use App\Repositories\ExpenseRepository;
 use App\Services\ExportService;
-use App\Services\ImportService;
 use Illuminate\Http\RedirectResponse;
 use Illuminate\Http\Request;
 use Illuminate\View\View;

diff --git a/app/Http/Controllers/Admin/FlightController.php b/app/Http/Controllers/Admin/FlightController.php
@@ -12,7 +12,6 @@
 use App\Models\FlightField;
 use App\Models\FlightFieldValue;
 use App\Repositories\AirlineRepository;
-use App\Repositories\AirportRepository;
 use App\Repositories\FareRepository;
 use App\Repositories\FlightFieldRepository;
 use App\Repositories\FlightRepository;
@@ -21,7 +20,6 @@
 use App\Services\FareService;
 use App\Services\FleetService;
 use App\Services\FlightService;
-use App\Services\ImportService;
 use App\Support\Units\Time;
 use Illuminate\Http\RedirectResponse;
 use Illuminate\Http\Request;

diff --git a/app/Http/Controllers/Admin/UserController.php b/app/Http/Controllers/Admin/UserController.php
@@ -10,7 +10,6 @@
 use App\Models\User;
 use App\Models\UserAward;
 use App\Repositories\AirlineRepository;
-use App\Repositories\AirportRepository;
 use App\Repositories\PirepRepository;
 use App\Repositories\RoleRepository;
 use App\Repositories\TypeRatingRepository;

diff --git a/app/Http/Controllers/Api/AcarsController.php b/app/Http/Controllers/Api/AcarsController.php
@@ -63,7 +63,7 @@ protected function checkCancelled(Pirep $pirep): void
     public function live_flights()
     {
         $pireps = $this->acarsRepo->getPositions(setting('acars.live_time'))->filter(
-            fn(Pirep $pirep) => $pirep->position !== null
+            fn (Pirep $pirep) => $pirep->position !== null
         );
 
         return PirepResource::collection($pireps);

diff --git a/app/Http/Controllers/Auth/RegisterController.php b/app/Http/Controllers/Auth/RegisterController.php
@@ -9,7 +9,6 @@
 use App\Models\UserField;
 use App\Models\UserFieldValue;
 use App\Repositories\AirlineRepository;
-use App\Repositories\AirportRepository;
 use App\Services\UserService;
 use App\Support\Countries;
 use App\Support\HttpClient;
@@ -160,6 +159,7 @@ function ($attribute, $value, $fail) {
      * Get a validator for an incoming registration request.
      *
      * @param Request $request
+     *
      * @return User
      */
     protected function create(Request $request): User

diff --git a/app/Http/Controllers/Frontend/HomeController.php b/app/Http/Controllers/Frontend/HomeController.php
@@ -6,7 +6,6 @@
 use App\Models\Enums\UserState;
 use App\Models\User;
 use Illuminate\Database\Eloquent\Collection;
-use Illuminate\Database\QueryException;
 use Illuminate\Support\Facades\Log;
 use Illuminate\View\View;
 

diff --git a/app/Http/Controllers/Frontend/ProfileController.php b/app/Http/Controllers/Frontend/ProfileController.php
@@ -8,7 +8,6 @@
 use App\Models\UserField;
 use App\Models\UserFieldValue;
 use App\Repositories\AirlineRepository;
-use App\Repositories\AirportRepository;
 use App\Repositories\UserRepository;
 use App\Support\Countries;
 use App\Support\Timezonelist;

diff --git a/app/Models/Expense.php b/app/Models/Expense.php
@@ -10,15 +10,15 @@
 use Illuminate\Database\Eloquent\Relations\MorphTo;
 
 /**
- * @property int     $airline_id
- * @property float   $amount
- * @property string  $name
- * @property string  $type
+ * @property int      $airline_id
+ * @property float    $amount
+ * @property string   $name
+ * @property string   $type
  * @property string[] $flight_type
- * @property string  $ref_model
- * @property string  $ref_model_id
- * @property bool    $charge_to_user
- * @property Airline $airline
+ * @property string   $ref_model
+ * @property string   $ref_model_id
+ * @property bool     $charge_to_user
+ * @property Airline  $airline
  *
  * @mixin \Illuminate\Database\Eloquent\Builder
  */

diff --git a/app/Models/Fare.php b/app/Models/Fare.php
@@ -3,7 +3,6 @@
 namespace App\Models;
 
 use App\Contracts\Model;
-use App\Models\Enums\FareType;
 use Illuminate\Database\Eloquent\Factories\HasFactory;
 use Illuminate\Database\Eloquent\Relations\BelongsToMany;
 use Illuminate\Database\Eloquent\SoftDeletes;

diff --git a/app/Models/Flight.php b/app/Models/Flight.php
@@ -21,43 +21,43 @@
 use Kyslik\ColumnSortable\Sortable;
 
 /**
- * @property string     $id
- * @property mixed      $ident
- * @property mixed      $atc
- * @property Airline    $airline
- * @property int        $airline_id
- * @property mixed      $flight_number
- * @property mixed      $callsign
- * @property mixed      $route_code
- * @property int        $route_leg
- * @property bool       $has_bid
+ * @property string                            $id
+ * @property mixed                             $ident
+ * @property mixed                             $atc
+ * @property Airline                           $airline
+ * @property int                               $airline_id
+ * @property mixed                             $flight_number
+ * @property mixed                             $callsign
+ * @property mixed                             $route_code
+ * @property int                               $route_leg
+ * @property bool                              $has_bid
  * @property Collection<int, FlightFieldValue> $field_values
- * @property Collection<int, Fare> $fares
- * @property Collection<int, Subfleet> $subfleets
- * @property int        $days
- * @property Distance   $distance
- * @property Distance   $planned_distance
- * @property int        $flight_time
- * @property string     $route
- * @property string     $dpt_time
- * @property string     $arr_time
- * @property string     $flight_type
- * @property string     $notes
- * @property int        $level
- * @property float      $load_factor
- * @property float      $load_factor_variance
- * @property float      $pilot_pay
- * @property Airport    $dpt_airport
- * @property Airport    $arr_airport
- * @property ?Airport   $alt_airport
- * @property string     $dpt_airport_id
- * @property string     $arr_airport_id
- * @property ?string    $alt_airport_id
- * @property int        $event_id
- * @property int        $user_id
- * @property int        $active
- * @property Carbon     $start_date
- * @property Carbon     $end_date
+ * @property Collection<int, Fare>             $fares
+ * @property Collection<int, Subfleet>         $subfleets
+ * @property int                               $days
+ * @property Distance                          $distance
+ * @property Distance                          $planned_distance
+ * @property int                               $flight_time
+ * @property string                            $route
+ * @property string                            $dpt_time
+ * @property string                            $arr_time
+ * @property string                            $flight_type
+ * @property string                            $notes
+ * @property int                               $level
+ * @property float                             $load_factor
+ * @property float                             $load_factor_variance
+ * @property float                             $pilot_pay
+ * @property Airport                           $dpt_airport
+ * @property Airport                           $arr_airport
+ * @property ?Airport                          $alt_airport
+ * @property string                            $dpt_airport_id
+ * @property string                            $arr_airport_id
+ * @property ?string                           $alt_airport_id
+ * @property int                               $event_id
+ * @property int                               $user_id
+ * @property int                               $active
+ * @property Carbon                            $start_date
+ * @property Carbon                            $end_date
  */
 class Flight extends Model
 {

diff --git a/app/Models/Ledger.php b/app/Models/Ledger.php
@@ -14,11 +14,11 @@
 /**
  * Class Ledger
  *
- * @property Money                $balance
- * @property string               $currency
- * @property Carbon               $updated_at
- * @property Carbon               $post_date
- * @property Carbon               $created_at
+ * @property Money                               $balance
+ * @property string                              $currency
+ * @property Carbon                              $updated_at
+ * @property Carbon                              $post_date
+ * @property Carbon                              $created_at
  * @property Collection<int, JournalTransaction> $journal_transctions
  */
 class Ledger extends Model

diff --git a/app/Models/Observers/JournalTransactionObserver.php b/app/Models/Observers/JournalTransactionObserver.php
@@ -3,7 +3,6 @@
 namespace App\Models\Observers;
 
 use App\Models\JournalTransaction;
-use App\Support\Money;
 
 /**
  * Class JournalTransactionObserver

diff --git a/app/Models/PirepFare.php b/app/Models/PirepFare.php
@@ -3,7 +3,6 @@
 namespace App\Models;
 
 use App\Contracts\Model;
-use App\Models\Enums\FareType;
 use Illuminate\Database\Eloquent\Relations\BelongsTo;
 
 /**

diff --git a/app/Models/Rank.php b/app/Models/Rank.php
@@ -12,14 +12,14 @@
 use Kyslik\ColumnSortable\Sortable;
 
 /**
- * @property string $name
- * @property int    $hours
- * @property string $image_url
- * @property float  $manual_base_pay_rate
- * @property float  $acars_base_pay_rate
- * @property bool   $auto_promote
- * @property bool   $auto_approve_acars
- * @property bool   $auto_approve_manual
+ * @property string                    $name
+ * @property int                       $hours
+ * @property string                    $image_url
+ * @property float                     $manual_base_pay_rate
+ * @property float                     $acars_base_pay_rate
+ * @property bool                      $auto_promote
+ * @property bool                      $auto_approve_acars
+ * @property bool                      $auto_approve_manual
  * @property Collection<int, Subfleet> $subfleets
  */
 class Rank extends Model

diff --git a/app/Models/Subfleet.php b/app/Models/Subfleet.php
@@ -17,20 +17,20 @@
 use Kyslik\ColumnSortable\Sortable;
 
 /**
- * @property int        $id
- * @property string     $type
- * @property string     $simbrief_type
- * @property string     $name
- * @property int        $airline_id
- * @property ?string    $hub_id
- * @property int        $ground_handling_multiplier
+ * @property int                   $id
+ * @property string                $type
+ * @property string                $simbrief_type
+ * @property string                $name
+ * @property int                   $airline_id
+ * @property ?string               $hub_id
+ * @property int                   $ground_handling_multiplier
  * @property Collection<int, Fare> $fares
- * @property float      $cost_block_hour
- * @property float      $cost_delay_minute
- * @property Airline    $airline
- * @property ?Airport   $home
- * @property int        $fuel_type
- * @property Aircraft[] $aircraft
+ * @property float                 $cost_block_hour
+ * @property float                 $cost_delay_minute
+ * @property Airline               $airline
+ * @property ?Airport              $home
+ * @property int                   $fuel_type
+ * @property Aircraft[]            $aircraft
  */
 class Subfleet extends Model
 {