Skip to content

Commit

Permalink
Bump version to 1.5.0
Browse files Browse the repository at this point in the history
  • Loading branch information
marioizquierdo committed Apr 14, 2020
1 parent 248cc7a commit 52d1fa5
Show file tree
Hide file tree
Showing 7 changed files with 16 additions and 15 deletions.
7 changes: 4 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,18 @@ Features and bugfixes are managed through Github's Issues and Pull Requests. Con
* Run Go tests (test code generation): `cd protoc-gen-twirp_ruby` then `go test ./...`
* Run example code (see [example/README.md](example/README.md)).

## Make a new release (for authors only)
## Make a new release (authors only)

Once enough new features are added, a new release is drafted.

* Merge approved PRs into master.
* Update VERSION with semantinc versioning in:
* `lib/twirp/version.rb` and
* `protoc-gen-twirp_ruby/version.go`
* Update the example code with new features (if needed), and re-generate code (see [example/README.md](example/README.md)). Make sure that you are using the latest version of `protoc-gen-twirp_ruby`, if the repo is in `$GOPATH/src/github.com/twitchtv/twirp-ruby`, then you only need to do `go install github.com/twitchtv/twirp-ruby/protoc-gen-twirp_ruby` before running the `protoc` command to generate code. The generated code should be annotated with the new version.
* Run `bundle install` to update the `Gemfile.lock` file with the new version.
* Run tests.
* Run `rake` to run tests.
* Re-generate code (see [example/README.md](example/README.md)). Make sure to use the latest version of `protoc-gen-twirp_ruby`; if the repo is in `$GOPATH/src/github.com/twitchtv/twirp-ruby`, then you only need to do `go install github.com/twitchtv/twirp-ruby/protoc-gen-twirp_ruby` before running the `protoc` command to generate code. The generated code should be annotated with the new version.
* Update example code and README if needed with new features.
* Commit changes for the new version in master and push to remote.
* [Draft a new release](https://github.com/twitchtv/twirp-ruby/releases) in Github. Create a new tag with the version. Add release notes (see previous releases to keep the same format).
* Build the gem: `gem build twirp.gemspec` and then push the new .gem file to Ruby Gems: `gem push twirp-X.X.X.gem`. You can delete the .gem file after that.
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
twirp (1.4.1)
twirp (1.5.0)
faraday (< 2)
google-protobuf (~> 3.0, >= 3.0.0)

Expand Down
12 changes: 6 additions & 6 deletions example/Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
PATH
remote: ..
specs:
twirp (1.1.0)
faraday (~> 0)
twirp (1.5.0)
faraday (< 2)
google-protobuf (~> 3.0, >= 3.0.0)

GEM
remote: https://rubygems.org/
specs:
faraday (0.14.0)
faraday (1.0.1)
multipart-post (>= 1.2, < 3)
google-protobuf (3.5.1.2)
multipart-post (2.0.0)
google-protobuf (3.11.4)
multipart-post (2.1.1)
rack (2.0.8)

PLATFORMS
Expand All @@ -22,4 +22,4 @@ DEPENDENCIES
twirp!

BUNDLED WITH
1.16.1
1.17.2
4 changes: 2 additions & 2 deletions example/hello_world/service_pb.rb

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion example/hello_world/service_twirp.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Code generated by protoc-gen-twirp_ruby 1.3.0, DO NOT EDIT.
# Code generated by protoc-gen-twirp_ruby 1.4.1, DO NOT EDIT.
require 'twirp'
require_relative 'service_pb.rb'

Expand Down
2 changes: 1 addition & 1 deletion lib/twirp/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@
# permissions and limitations under the License.

module Twirp
VERSION = "1.4.1"
VERSION = "1.5.0"
end
2 changes: 1 addition & 1 deletion protoc-gen-twirp_ruby/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ package main

// Version is the same version in the ruby gem: lib/twirp/version.rb
// It helps identify what version of the code generator was used.
const Version = "1.4.1"
const Version = "1.5.0"

0 comments on commit 52d1fa5

Please sign in to comment.