Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added idea folder to gitignore #241

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

judemanutd
Copy link

idea files contain configs local to the users environment which can be completely different so it's best not to track idea files

@codecov-io
Copy link

codecov-io commented Jun 3, 2018

Codecov Report

Merging #241 into master will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #241      +/-   ##
============================================
+ Coverage     36.98%   37.19%   +0.21%     
  Complexity       45       45              
============================================
  Files            39       36       -3     
  Lines           530      527       -3     
  Branches         27       27              
============================================
  Hits            196      196              
+ Misses          325      322       -3     
  Partials          9        9
Impacted Files Coverage Δ Complexity Δ
...in/qualitymatters/performance/AsyncJobsModule.java
...alitymatters/network/OkHttpInterceptorsModule.java
...rs/developer_settings/DeveloperSettingsModule.java

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47e484b...8a95fec. Read the comment docs.

.gitignore Outdated
@@ -24,8 +24,9 @@ local.properties
.project

# Idea IDE files
/.idea/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the first slash?

Copy link
Author

@judemanutd judemanutd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine now

@artem-zinnatullin
Copy link
Owner

Can you please add exception !.idea/codeStyleSetting.xml because we intentionally share it? Otherwise lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants