Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add ruby 3.4 #696

Merged
merged 4 commits into from
Dec 28, 2024
Merged

CI: Add ruby 3.4 #696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b2f57a
CI: Add ruby 3.4
ylecuyer Dec 28, 2024
1cf751c
Fix spec
ylecuyer Dec 28, 2024
738ac8c
fix specs for all ruby versions
ylecuyer Dec 28, 2024
fc68cc8
empty commit
ylecuyer Dec 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: [2.7, "3.0", 3.1, 3.2, 3.3, head]
ruby: [2.7, "3.0", 3.1, 3.2, 3.3, 3.4, head]

steps:
- name: Checkout repository
Expand Down
2 changes: 2 additions & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ Internal improvements:

Testing improvements:

* Add ruby 3.4 to CI ([696](https://github.com/arsduo/koala/pull/696))

Others:

v3.6.0 (2024-06-27)
Expand Down
24 changes: 18 additions & 6 deletions spec/cases/http_service_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,17 +238,25 @@ def adapter(arg)
it 'logs tokens' do
allow(Koala.config).to receive(:mask_tokens) { false }

expect(Koala::Utils).to receive(:debug).with('STARTED => GET: /foo params: {"an"=>:arg, "access_token"=>"myvisbleaccesstoken"}')
expect(Koala::Utils).to receive(:debug).with('FINISHED => GET: /foo params: {"an"=>:arg, "access_token"=>"myvisbleaccesstoken"}')
expect(Koala::Utils).to receive(:debug) do |log|
expect(log).to match(/STARTED => GET: \/foo params: {"an"\s?=>\s?:arg, "access_token"\s?=>\s?"myvisbleaccesstoken"}/)
end
expect(Koala::Utils).to receive(:debug) do |log|
expect(log).to match(/FINISHED => GET: \/foo params: {"an"\s?=>\s?:arg, "access_token"\s?=>\s?"myvisbleaccesstoken"}/)
end

Koala::HTTPService.make_request(request)
end

it 'doesnt log tokens' do
allow(Koala.config).to receive(:mask_tokens) { true }

expect(Koala::Utils).to receive(:debug).with('STARTED => GET: /foo params: {"an"=>:arg, "access_token"=>"myvisbleac*****token"}')
expect(Koala::Utils).to receive(:debug).with('FINISHED => GET: /foo params: {"an"=>:arg, "access_token"=>"myvisbleac*****token"}')
expect(Koala::Utils).to receive(:debug) do |log|
expect(log).to match(/STARTED => GET: \/foo params: {"an"\s?=>\s?:arg, "access_token"\s?=>\s?"myvisbleac[*]{5}token"}/)
end
expect(Koala::Utils).to receive(:debug) do |log|
expect(log).to match(/FINISHED => GET: \/foo params: {"an"\s?=>\s?:arg, "access_token"\s?=>\s?"myvisbleac[*]{5}token"}/)
end

Koala::HTTPService.make_request(request)
end
Expand All @@ -258,8 +266,12 @@ def adapter(arg)

allow(Koala.config).to receive(:mask_tokens) { true }

expect(Koala::Utils).to receive(:debug).with('STARTED => GET: /debug_token params: {"input_token"=>"myvisiblea*****token", "access_token"=>"myvisiblea*****token"}')
expect(Koala::Utils).to receive(:debug).with('FINISHED => GET: /debug_token params: {"input_token"=>"myvisiblea*****token", "access_token"=>"myvisiblea*****token"}')
expect(Koala::Utils).to receive(:debug) do |log|
expect(log).to match(/STARTED => GET: \/debug_token params: {"input_token"\s?=>\s?"myvisiblea[*]{5}token", "access_token"\s?=>\s?"myvisiblea[*]{5}token"}/)
end
expect(Koala::Utils).to receive(:debug) do |log|
expect(log).to match(/FINISHED => GET: \/debug_token params: {"input_token"\s?=>\s?"myvisiblea[*]{5}token", "access_token"\s?=>\s?"myvisiblea[*]{5}token"}/)
end

Koala::HTTPService.make_request(request)
end
Expand Down
Loading