Handle response when http_component is set and include logging of x-fb-debug, x-fb-rev #648
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR includes changes which will help use the latest koala version when
http_component
is setChanges included:
http_component
is set, we receiveKoala::Http_service response
instead of a hash andgenerate_results
method handles only JSON response. This affects all batch request.x-fb-trace-id
andx-fb-debug x-fb-rev
as part of the error_message returned[X] My PR has tests and they pass!