-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve todo-mvc example #354
Conversation
RoelVanderPaal
commented
Feb 24, 2024
- implement HTML as defined in https://github.com/tastejs/todomvc-app-template
- implement full app specification: https://github.com/tastejs/todomvc/blob/master/app-spec.md
- toggle-all button
- editing:
- trim text
- remove when empty
- undo on escape key
- clear-completed button
- localStorage Json format
- implement full app specification: https://github.com/tastejs/todomvc/blob/master/app-spec.md - toggle-all button - editing: - trim text - remove when empty - undo on escape key - clear-completed button
Co-authored-by: Arman Bilge <[email protected]>
FYI, I tested with https://github.com/RoelVanderPaal/playwright/tree/main/examples/todomvc |
Cool! Does Playwright have a Java API? Would be cool to have those tests integrated into our test suite. Actually, at least a couple other Scala.js UI frameworks could share them as well :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your work on this!! looks great :)
It does indeed. Porting the tests from Javascript to Java is probably not a lot of work. |
A bit more complicated but also doable! If you decide to port the tests from JS to Scala/Java I would love to make it part of the test suite here. |