Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve todo-mvc example #354

Merged
merged 6 commits into from
Feb 29, 2024
Merged

Conversation

RoelVanderPaal
Copy link
Contributor

- implement full app specification: https://github.com/tastejs/todomvc/blob/master/app-spec.md
  - toggle-all button
  - editing:
    - trim text
    - remove when empty
    - undo on escape key
  - clear-completed button
@RoelVanderPaal
Copy link
Contributor Author

@armanbilge
Copy link
Owner

FYI, I tested with https://github.com/RoelVanderPaal/playwright/tree/main/examples/todomvc

Cool! Does Playwright have a Java API? Would be cool to have those tests integrated into our test suite. Actually, at least a couple other Scala.js UI frameworks could share them as well :)

Copy link
Owner

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your work on this!! looks great :)

@armanbilge armanbilge merged commit 5d4c10f into armanbilge:main Feb 29, 2024
7 checks passed
@RoelVanderPaal
Copy link
Contributor Author

FYI, I tested with https://github.com/RoelVanderPaal/playwright/tree/main/examples/todomvc

Cool! Does Playwright have a Java API? Would be cool to have those tests integrated into our test suite. Actually, at least a couple other Scala.js UI frameworks could share them as well :)

It does indeed. Porting the tests from Javascript to Java is probably not a lot of work.
Running the tests automatically is a bit more complicated since the tested application must be served over HTTP.

@armanbilge
Copy link
Owner

Running the tests automatically is a bit more complicated since the tested application must be served over HTTP.

A bit more complicated but also doable! If you decide to port the tests from JS to Scala/Java I would love to make it part of the test suite here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants