-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ligero univariate and multilinear PCS #132
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hossein Moghaddas <[email protected]> Co-authored-by: Antonio Mejías Gil <[email protected]>
mmagician
requested review from
z-tech,
Pratyush and
weikengchen
and removed request for
a team
October 25, 2023 10:20
Pratyush
approved these changes
Oct 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 25, 2024
autquis
force-pushed
the
ligero-uni-and-ml
branch
from
October 25, 2024 12:34
3f25cc0
to
921d8ca
Compare
This PR is ready now! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 25, 2024
Hmm, I think the last commit fixes the issue with the CI. I'm not sure why it did not appear earlier on. 🤔 Edit: It seems to be a network failure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supersedes #125: we have refactored our original (univariate) Ligero codebase to support other linear code PC schemes (multilinear Ligero, Brakedown). This requires the implementers of new linear code schemes to implement
LinearEncode
andLinCodeParametersInfo
, where most methods are trivial and the core logic contained inencode
. Perhaps there's some simplifications to be done to the traits still.closes: #125
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the Github PR explorer