Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Grain LFSR test cases #118

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

Insun35
Copy link
Contributor

@Insun35 Insun35 commented Sep 23, 2023

Description

  • Refactoring: replace unnecessarily duplicated code in the init() to calling update().
  • Test: add more test cases for get_field_elements_mod_p in the Grain LFSR consistency test.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@Pratyush
Copy link
Member

Thanks for the cleanup and tests!

@Pratyush Pratyush merged commit 4dbaf62 into arkworks-rs:main Sep 26, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants