Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ff: add unit tests for BitIterator #874

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

tcoratger
Copy link
Contributor

Description


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@tcoratger tcoratger requested review from a team as code owners November 13, 2024 21:11
@tcoratger tcoratger requested review from z-tech, Pratyush and tyshko-rostyslav and removed request for a team November 13, 2024 21:11
@Pratyush
Copy link
Member

thank you! a randomized fuzz-style test might be even better: generating random u64s, bit decomposing them, and checking that the output of BitIterator matches.

@Pratyush Pratyush added this pull request to the merge queue Nov 14, 2024
Merged via the queue into arkworks-rs:master with commit 16239f0 Nov 14, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants